API-40902 - Remove flipper for VA Notify, update associated tests

[mchristiansonVA]

Summary

• This work is behind a feature toggle (flipper): NO
• Removes flipper lighthouse_claims_api_v2_poa_va_notify as part of follow-on cleanup work for the VA Notify functionality used with POA requests.
• Updates associated rspec tests

Related issue(s)

API-40902

Testing done

• New code is covered by unit tests
• Confirmed that calls to POA request decide endpoint result in appropriate VA Notify emails being sent for declined & approved decisions for both representative and organization requests.

What areas of the site does it impact?

modules/claims_api/app/controllers/claims_api/v2/veterans/power_of_attorney/request_controller.rb
modules/claims_api/spec/controllers/v2/veterans/power_of_attorney/request_controller_spec.rb
modules/claims_api/spec/sidekiq/poa_assign_dependent_claimant_job_spec.rb
modules/claims_api/spec/sidekiq/poa_updater_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[rockwellwindsor-va]

@mchristiansonVA Looks like a POA test is failing, is that related?

[mchristiansonVA]

Looks like a POA test is failing, is that related?

I re-ran the tests and now getting a different failure, also related to pdfs, so I think it's just the usual pdf test-related flakiness.

[rockwellwindsor-va]

Need to remove reference from the features.yml file. Iwill watch for the update, everything else looked good to go

[rockwellwindsor-va]

Glad to get another Flipper out, LGTM!