-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix max file size limit #21004
Open
michelpmcdonald
wants to merge
7
commits into
master
Choose a base branch
from
API-45306-bi-max-file-size-limit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix max file size limit #21004
+14
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristen-brown
requested changes
Mar 3, 2025
modules/vba_documents/lib/vba_documents/document_request_validator.rb
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
banana-peels
Lighthouse Banana Peels Team
benefits-intake
Lighthouse Benefits Intake API
Lighthouse
lighthouse
require-backend-approval
test-passing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
No feature flag, bug fix.
Currently, benefits intake has a per PDF max file size limit documented as 100 MB.
Internally our code uses 1,000,000 bytes as the max file size, however 100 MB is actually 1,048,576 bytes.
To reproduce, send in a 99 MB PDF file, we reject it even though it is less than 100 MB
The solution was is to change our max file size limit in bytes to 1,048,576 and adjust other places in the code(mostly unit test) that used decimal kb sizing(1000 bytes per kb) to binary kb sizing(1024 bytes per kb).
I did confirm with central mail(EMMS API), the recipient of these files that they are using binary\1024 bytes per kb and now we should be in alignment with them.
I don't think this will negatively impact consumers considering that we are now allowing slightly bigger files as intended.
Team banapeels, we own this code
Related issue(s)
https://jira.devops.va.gov/browse/API-45306
Testing done
-We already had pretty good unit test coverage, but they had to be adjusted because they were set up on decimal sizing where 1000 bytes equals a kilobyte, so i changed them to the proper 1024 bytes equals a kilobyte
What areas of the site does it impact?
Benefits Intake uploads
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?