Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Rack 3.0.13 #21076

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Update to Rack 3.0.13 #21076

wants to merge 5 commits into from
+18 −264

Conversation

ericboehs
Copy link
Contributor

No description provided.

@va-vfs-bot va-vfs-bot temporarily deployed to eb-rack-3-0-dev-only-borked/main/main March 4, 2025 17:10 Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: spec/requests/v0/prescriptions_spec.rb

@ericboehs ericboehs force-pushed the eb-rack-3-0-dev-only-borked branch from 3923e24 to 78bfb16 Compare March 4, 2025 17:11
@va-vfs-bot va-vfs-bot temporarily deployed to eb-rack-3-0-dev-only-borked/main/main March 4, 2025 17:28 Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

1 Warning
⚠️ This PR changes 213 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • .github/CODEOWNERS (+0/-1)

  • .github/workflows/build.yml (+4/-6)

  • Gemfile (+1/-1)

  • app/controllers/concerns/filterable.rb (+1/-1)

  • spec/requests/v0/prescriptions_spec.rb (+0/-197)

  • spec/serializers/intent_to_file_serializer_spec.rb (+1/-0)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to eb-rack-3-0-dev-only-borked/main/main March 4, 2025 17:37 Inactive
ericboehs added 2 commits March 4, 2025 11:57
@ericboehs
fix: require IntentToFilesResponse to resolve error
4508e53 
The uninitialized constant error was due to missing the require
statement for `IntentToFilesResponse`. Adding this resolves the
issue in the serializer spec.

When running `rspec spec/serializers/intent_to_file_serializer_spec.rb`
alone, this error occured:

```
uninitialized constant EVSS::IntentToFile::IntentToFilesResponse
```
@ericboehs
wip: allow deploys rm me
daf7a54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test-failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericboehs @va-vfs-bot