Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Payments] No longer show payments disbursed to a third party #21082

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

iandonovan
Copy link
Contributor

@iandonovan iandonovan commented Mar 4, 2025

Summary

  • This work is behind a feature toggle (flipper): YES, there are two of them.
  1. payment_history_exclude_third_party_disbursements, when enabled, ensures a user looking at Payment History will only see payments that were disbursed to them.
  2. payment_history_recategorize_hardship, when abled, will recategorize some payments currently marked as Hardship as Chapter 33 Hardship instead.
  • I am on Benefits Management 2

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Prior to this, a user looking at Payment History would see payments that were disbursed to others, like their dependents. This could introduce confusion if they interpreted the information as, e.g., seeing a payment on the page that they hadn't received.
  • The recategorization is a separate issue. I am not entirely sure this change will be necessary if we are only showing payments disbursed to the user viewing the page, but we'll see.

What areas of the site does it impact?

  • This is entirely confined within Payment History.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@iandonovan iandonovan added BMT2 Benefits Management Team 2 benefits-management-tools labels Mar 4, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to 95240-payment-history/main/main March 4, 2025 19:43 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 95240-payment-history/main/main March 5, 2025 16:35 Inactive
@iandonovan iandonovan marked this pull request as ready for review March 5, 2025 17:45
@iandonovan iandonovan requested review from a team as code owners March 5, 2025 17:45
@iandonovan iandonovan marked this pull request as draft March 5, 2025 21:57
@va-vfs-bot va-vfs-bot temporarily deployed to 95240-payment-history/main/main March 5, 2025 21:59 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 95240-payment-history/main/main March 6, 2025 19:32 Inactive
@iandonovan iandonovan marked this pull request as ready for review March 7, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Payment History showing incorrect information
2 participants