Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

103918 Add production support/convenience functions to module - IVC CHAMPVA #21111

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

michaelclement
Copy link
Contributor

@michaelclement michaelclement commented Mar 5, 2025

Summary

This PR adds the new production support helpers and an initial unit test to the IVC CHAMPVA module. These helpers provide convenient methods for viewing batches of form submissions for cases when we want to do some inspection/pull some metrics.

  • *This work is behind a feature toggle (flipper): NO
  • Team: IVC CHAMPVA

Related issue(s)

Testing done

  • New code is covered by unit tests
  • To verify this functionality, start up vets-api and add some IvcChampvaForm objects (as per the unit test) then run the new commands in the console and observe the output.

Screenshots

NA

What areas of the site does it impact?

IVC CHAMPVA module only

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

NA

@va-vfs-bot va-vfs-bot temporarily deployed to 103918-add-prod-support-features-ivc/main/main March 5, 2025 22:19 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 103918-add-prod-support-features-ivc/main/main March 5, 2025 22:38 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 103918-add-prod-support-features-ivc/main/main March 7, 2025 20:59 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 103918-add-prod-support-features-ivc/main/main March 7, 2025 21:08 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 103918-add-prod-support-features-ivc/main/main March 7, 2025 21:27 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 103918-add-prod-support-features-ivc/main/main March 7, 2025 22:14 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants