Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

102836: Update vets-json-schema version #21132

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dfong-adh
Copy link
Contributor

@dfong-adh dfong-adh commented Mar 6, 2025

Summary

  • This work is behind a feature toggle (flipper): YES/NO
    No

This updates the vets-json-schema gem version to support the latest version of the schmea for Supplemental Claims create endpoint.

This is owned by the Benefits Decision Review team.

Related issue(s)

department-of-veterans-affairs/va.gov-team#102836

Testing done

  • New code is covered by unit tests
    The schema changes are backwards compatible and adds new optional fields

What areas of the site does it impact?

Decision Review Supplemental Claims create endpoint

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@dfong-adh dfong-adh requested review from a team March 6, 2025 18:56
Mottie
Mottie previously approved these changes Mar 6, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to 102836-update-vets-json-schema-version/main/main March 6, 2025 19:14 Inactive
@dfong-adh dfong-adh marked this pull request as ready for review March 6, 2025 21:02
@dfong-adh dfong-adh requested a review from a team as a code owner March 6, 2025 21:02
@dfong-adh
Copy link
Contributor Author

Test ./spec/lib/pdf_fill/forms/va21p0969_spec.rb failing due to other vets-json-schema changes, waiting for #20970 to be merged.

@va-vfs-bot va-vfs-bot temporarily deployed to 102836-update-vets-json-schema-version/main/main March 7, 2025 15:58 Inactive
@comaurice
Copy link

@CorySohrakoffUSDS FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants