Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-45277 - Updates to VnpProcServiceV2 for POA request creation #21140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

API-45277 - Updates to VnpProcServiceV2 for POA request creation #21140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/claims_api/app/services/claims_api/power_of_attorney_request_service/orchestrator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ def initialize(veteran_participant_id, form_data, claimant_participant_id = nil,
end

def submit_request
ClaimsApi::PowerOfAttorneyRequestService::TerminateExistingRequests.new(@veteran_participant_id).call
# Disabling logic to terminate existing requests until future permanent fix
# ClaimsApi::PowerOfAttorneyRequestService::TerminateExistingRequests.new(@veteran_participant_id).call
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mchristiansonVA Why do we need to disable this here? Is it because of the '21-22 ' thing? Just want to make sure I understand why we need this change too.

Copy link
Contributor Author

@mchristiansonVA mchristiansonVA Mar 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment in the summary—this was done because we were having issues with the read_all_veteran_representatives call breaking the flow before we got to the create steps, and we decided in standup to just take this approach at the time. But looking again I think you addressed the issue with the handling an empty list of obsolete requests. I'll update to remove the disabling.

ClaimsApi::PowerOfAttorneyRequestService::CreateRequest.new(@veteran_participant_id, @form_data,
@claimant_participant_id, @poa_key).call
end
Expand Down
11 changes: 8 additions & 3 deletions modules/claims_api/lib/bgs_service/vnp_proc_service_v2.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,22 @@
module ClaimsApi
class VnpProcServiceV2 < ClaimsApi::LocalBGS
PROC_TYPE_CD = 'POAAUTHZ'
PROC_STATE = 'Complete'

def bean_name
'VnpProcWebServiceBeanV2/VnpProcServiceV2'
end

def vnp_proc_create
current_date = Time.current.iso8601
body = Nokogiri::XML::DocumentFragment.parse <<~EOXML
<arg0>
<VnpProcDTO>
<vnpProcTypeCd>#{PROC_TYPE_CD}</vnpProcTypeCd>
</VnpProcDTO>
<vnpProcId>0</vnpProcId>
<vnpProcTypeCd>#{PROC_TYPE_CD}</vnpProcTypeCd>
<vnpProcStateTypeCd>#{PROC_STATE}</vnpProcStateTypeCd>
<creatdDt>#{current_date}</creatdDt>
<lastModifdDt>#{current_date}</lastModifdDt>
<submtdDt>#{current_date}</submtdDt>
</arg0>
EOXML

Expand Down
Loading