Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VI-1120] Load IdentitySettings secrets #21147

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[VI-1120] Load IdentitySettings secrets #21147

wants to merge 2 commits into from

Conversation

rileyanderson
Copy link
Contributor

@rileyanderson rileyanderson commented Mar 6, 2025

Summary

  • Load Identity secrets into IdentitySettings from the ENV

Related issue(s)

Testing

  • Start rails console with env var IDENTITY_SETTINGS__IDME__CLIENT_SECRET=some-secret
     IDENTITY_SETTINGS__IDME__CLIENT_SECRET=some-secret rails c
  • Check setting
    IdentitySettings.idme.client_secret

What areas of the site does it impact?

IdentitySettings

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Copy link

github-actions bot commented Mar 6, 2025

1 Warning
⚠️ This PR changes 282 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • .github/CODEOWNERS (+2/-0)

  • .gitignore (+2/-1)

  • config/identity_settings/environments/dev.yml (+50/-0)

  • config/identity_settings/environments/localhost.yml (+2/-0)

  • config/identity_settings/environments/production.yml (+70/-0)

  • config/identity_settings/environments/staging.yml (+56/-0)

  • config/identity_settings/settings.yml (+89/-0)

  • config/initializers/identity_config.rb (+10/-0)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants