Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to fix failing requests #21148

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −10
Draft

Trying to fix failing requests #21148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion modules/mobile/spec/models/user_accessible_services_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
describe 'claims' do
context 'with mobile_lighthouse_claims flag off' do
before { Flipper.disable(:mobile_lighthouse_claims) }
after { Flipper.enable(:mobile_lighthouse_claims) }

context 'when user does not have evss access' do
let(:user) { non_evss_user }
Expand Down
5 changes: 4 additions & 1 deletion modules/mobile/spec/requests/mobile/v0/claims_and_appeals_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@
end
end

after { Flipper.disable(:mobile_claims_log_decision_letter_sent) }
after do
Flipper.disable(:mobile_claims_log_decision_letter_sent)
Flipper.enable(:mobile_lighthouse_claims)
end

describe '#index is polled an unauthorized user' do
it 'and not user returns a 401 status' do
Expand Down
2 changes: 1 addition & 1 deletion modules/mobile/spec/requests/mobile/v0/evss_claim_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
let!(:user) { sis_user }

before do
Flipper.disable(:mobile_lighthouse_claims)
allow(Flipper).to receive(:enabled?).with(:mobile_lighthouse_claims, instance_of(User)).and_return(false)
create(:evss_claim, id: 1, evss_id: 600_117_255, user_uuid: user.uuid)
create(:evss_claim, id: 2, evss_id: 111_222_333, user_uuid: '1234567890')
end
Expand Down
2 changes: 0 additions & 2 deletions modules/mobile/spec/requests/mobile/v0/lighthouse_claim_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
Flipper.enable_actor(:mobile_lighthouse_claims, user)
end

after { Flipper.disable(:mobile_lighthouse_claims) }

context 'when the claim is found' do
before do
allow(Flipper).to receive(:enabled?).and_call_original
Expand Down
2 changes: 1 addition & 1 deletion modules/mobile/spec/requests/mobile/v0/user_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
before do
allow(Flipper).to receive(:enabled?).with(:remove_pciu, instance_of(User)).and_return(true)
allow(Flipper).to receive(:enabled?).with(:mobile_lighthouse_letters, instance_of(User)).and_return(false)
allow(Flipper).to receive(:enabled?).with(:mobile_lighthouse_claims, instance_of(User)).and_return(false)
allow(Flipper).to receive(:enabled?).with(:mobile_lighthouse_claims, instance_of(User)).and_return(true)
allow(Flipper).to receive(:enabled?).with(:mobile_lighthouse_direct_deposit, instance_of(User)).and_return(false)
allow(Flipper).to receive(:enabled?).with(:mobile_lighthouse_disability_ratings,
instance_of(User)).and_return(false)
Expand Down
4 changes: 0 additions & 4 deletions modules/mobile/spec/sidekiq/legacy_pre_cache_claims_and_appeals_job_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@
end

before(:all) do
Flipper.disable(:mobile_lighthouse_claims)
end

after do
Flipper.enable(:mobile_lighthouse_claims)
end

Expand Down
Loading