Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE example sign in service sso #21150

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+51 −4
Draft

DO NOT MERGE example sign in service sso #21150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 38 additions & 4 deletions app/controllers/v0/sign_in_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@
acr = params[:acr].presence
operation = params[:operation].presence || SignIn::Constants::Auth::AUTHORIZE
scope = params[:scope].presence
prompt = params[:prompt].presence

validate_authorize_params(type, client_id, acr, operation)

delete_cookies if token_cookies
delete_cookies if token_cookies && prompt != 'sso'

acr_for_type = SignIn::AcrTranslator.new(acr:, type:).perform
state = SignIn::StatePayloadJwtEncoder.new(code_challenge:,
Expand All @@ -36,9 +37,12 @@
sign_in_logger.info('authorize', context)
StatsD.increment(SignIn::Constants::Statsd::STATSD_SIS_AUTHORIZE_SUCCESS,
tags: ["type:#{type}", "client_id:#{client_id}", "acr:#{acr}", "operation:#{operation}"])

render body: auth_service(type, client_id).render_auth(state:, acr: acr_for_type, operation:),
content_type: 'text/html'
if prompt == 'sso' && cookies[SignIn::Constants::Auth::ACCESS_TOKEN_COOKIE_NAME]
sso_flow(state)
else
render body: auth_service(type, client_id).render_auth(state:, acr: acr_for_type, operation:),
content_type: 'text/html'
end
rescue SignIn::Errors::StandardError => e
sign_in_logger.info('authorize error', { errors: e.message, client_id:, type:, acr: })
StatsD.increment(SignIn::Constants::Statsd::STATSD_SIS_AUTHORIZE_FAILURE)
Expand Down Expand Up @@ -226,6 +230,36 @@

private

def sso_flow(state)

Check failure on line 233 in app/controllers/v0/sign_in_controller.rb

View workflow job for this annotation

GitHub Actions / Linting and Security 

Metrics/MethodLength: Method has too many lines. [25/20]
access_token_jwt = cookies[SignIn::Constants::Auth::ACCESS_TOKEN_COOKIE_NAME]
access_token = SignIn::AccessTokenJwtDecoder.new(access_token_jwt:).perform(with_validation: true)
state_payload = SignIn::StatePayloadJwtDecoder.new(state_payload_jwt: state).perform
SignIn::StatePayloadVerifier.new(state_payload:).perform
session = SignIn::OAuthSession.find_by(handle: access_token.session_handle)
user_attributes = JSON.parse(session.user_attributes)
user_attributes = {
idme_uuid: session.user_verification.idme_uuid || session.user_verification.backing_idme_uuid,
logingov_uuid: session.user_verification.logingov_uuid,
credential_email: session.credential_email,
edipi: session.user_verification.dslogon_uuid,
mhv_credential_uuid: session.user_verification.mhv_uuid,
first_name: user_attributes[:first_name],
last_name: user_attributes[:last_name]
}
user_code_map = SignIn::UserCodeMapCreator.new(
user_attributes:, state_payload:, verified_icn: session.user_account.icn, request_ip: request.remote_ip
).perform

params_hash = { code: user_code_map.login_code, type: user_code_map.type }
params_hash.merge!(state: user_code_map.client_state) if user_code_map.client_state.present?

render body: SignIn::RedirectUrlGenerator.new(redirect_uri: user_code_map.client_config.redirect_uri,
terms_code: user_code_map.terms_code,
terms_redirect_uri: user_code_map.client_config.terms_of_use_url,
params_hash:).perform,
content_type: 'text/html'
end

def validate_authorize_params(type, client_id, acr, operation)
if client_config(client_id).blank?
raise SignIn::Errors::MalformedParamsError.new message: 'Client id is not valid'
Expand Down
13 changes: 13 additions & 0 deletions db/seeds/development.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,19 @@
terms_of_use_url: 'http://localhost:3001/terms-of-use',
refresh_token_duration: SignIn::Constants::RefreshToken::VALIDITY_LENGTH_LONG_DAYS)

vaweb = SignIn::ClientConfig.find_or_initialize_by(client_id: 'okta_test')
vaweb.update!(authentication: SignIn::Constants::Auth::COOKIE,
anti_csrf: true,
redirect_uri: 'fake://this-is-fake',
access_token_duration: SignIn::Constants::AccessToken::VALIDITY_LENGTH_SHORT_MINUTES,
access_token_audience: 'okta',
pkce: true,
logout_redirect_uri: 'http://localhost:3001',
enforced_terms: SignIn::Constants::Auth::VA_TERMS,
terms_of_use_url: 'http://localhost:3001/terms-of-use',
shared_sessions: true,
refresh_token_duration: SignIn::Constants::RefreshToken::VALIDITY_LENGTH_SHORT_MINUTES)

# Create Config for localhost mocked authentication client
vamobile_mock = SignIn::ClientConfig.find_or_initialize_by(client_id: 'vamobile_test')
vamobile_mock.update!(authentication: SignIn::Constants::Auth::API,
Expand Down
Loading