Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused appointments feature toggles - 4 #21154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JunTaoLuo
Copy link
Contributor

Summary

  • Removing an obsolete feature toggles for features that have been fully released.
  • Appointments tools team

Related issue(s)

Testing done

  • New code is covered by unit tests ensured existing tests pass

Screenshots

N/A

What areas of the site does it impact?

Appointments tools

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation) Will update documentation after PRs are merged and feature toggles fully deleted from Flipper
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Copy link

github-actions bot commented Mar 7, 2025

1 Warning
⚠️ This PR changes 360 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • config/features.yml (+0/-4)

  • modules/mobile/spec/requests/mobile/v0/appointments/cancel_spec.rb (+0/-8)

  • modules/mobile/spec/requests/mobile/v0/appointments/create_spec.rb (+0/-16)

  • modules/mobile/spec/requests/mobile/v0/appointments/facilities/clinics_spec.rb (+0/-22)

  • modules/mobile/spec/requests/mobile/v0/appointments/vaos_v2_spec.rb (+0/-2)

  • modules/vaos/app/services/vaos/session_service.rb (+1/-4)

  • modules/vaos/app/services/vaos/user_service.rb (+1/-29)

  • modules/vaos/app/sidekiq/vaos/extend_session_job.rb (+0/-10)

  • modules/vaos/spec/requests/vaos/v2/appointments_spec.rb (+0/-18)

  • modules/vaos/spec/requests/vaos/v2/community_care/eligibility_spec.rb (+0/-4)

  • modules/vaos/spec/requests/vaos/v2/eligibility_spec.rb (+0/-4)

  • modules/vaos/spec/requests/vaos/v2/facilities_spec.rb (+0/-10)

  • modules/vaos/spec/requests/vaos/v2/locations/clinics_spec.rb (+0/-1)

  • modules/vaos/spec/requests/vaos/v2/locations/slots_spec.rb (+0/-4)

  • modules/vaos/spec/requests/vaos/v2/scheduling/configurations_spec.rb (+0/-1)

  • modules/vaos/spec/services/ccra/referral_service_spec.rb (+0/-1)

  • modules/vaos/spec/services/user_service_spec.rb (+17/-149)

  • modules/vaos/spec/services/v2/appointment_service_spec.rb (+0/-18)

  • modules/vaos/spec/services/v2/mobile_facility_service_spec.rb (+0/-1)

  • modules/vaos/spec/services/v2/patients_service_spec.rb (+0/-8)

  • modules/vaos/spec/services/v2/systems_service_spec.rb (+0/-8)

  • modules/vaos/spec/sidekiq/extend_session_job_spec.rb (+0/-19)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants