-
Notifications
You must be signed in to change notification settings - Fork 73
MHV-68149 Migration to new MHV API Gateway #21157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
a6f17a8
MHV-68159 Migration to new MHV API Gateway
mmoyer-va d859e0c
MHV-68159 Added custom base bath
mmoyer-va 4e7adcd
Merge branch 'master' into MHV-68159-switch-to-api-gateway
mmoyer-va 863d026
MHV-68159 Fixes
mmoyer-va 01d5806
MHV-68159 Corrections to paths and headers
mmoyer-va 84d83dc
MHV-68159 More header fixes
mmoyer-va da89f79
Merge remote-tracking branch 'origin/master' into MHV-68159-switch-to…
mmoyer-va abeee7e
MHV-68159 Updated some specs/cassettes
mmoyer-va e14d343
MHV-68159 Spec updates
mmoyer-va 3cd7906
MHV-68159 Updates to fix MR client_spec tests
mmoyer-va 3d58bc3
MHV-68159 Attempting to get spec tests to pass in PR
mmoyer-va 0b26663
MHV-68159 Spec fix
mmoyer-va cf5283a
MHV-68159 spec fixes
mmoyer-va e270e92
MHV-68159 Fixed a linter error
mmoyer-va 7310138
MHV-68159 Converted bb client to use API Gateway
mmoyer-va 38bd7c2
Reverting unrelated change -- will do in another PR
mmoyer-va 0a27b43
MHV-68159 Updating tests
mmoyer-va 7fd4eb4
MHV-68159 Fixed tests
mmoyer-va b963bc0
MHV-68159 Fixed tests
mmoyer-va 680bbf5
Merge remote-tracking branch 'origin/master' into MHV-68159-switch-to…
mmoyer-va 23a9c6d
MHV-68149 Diagnosing test errors
mmoyer-va 1f2d990
MHV-68149 Reverting a change
mmoyer-va 7b8a26a
MHV-68149 Updated user eligibility and spec
mmoyer-va d7ee7ce
Merge remote-tracking branch 'origin/master' into MHV-68159-switch-to…
mmoyer-va 8d6722c
MHV-68149 Attempting to fix spec test
mmoyer-va 0083bc3
MHV-68149 Fix test
mmoyer-va 28d05d4
MHV-68149 Moving user_eligibility over fully to API Gateway
mmoyer-va bde8471
MHV-68159 Fixed error
mmoyer-va 18f27a1
MHV-68149 Fixed BB code
mmoyer-va 1c26bc7
Merge remote-tracking branch 'origin/master' into MHV-68159-switch-to…
mmoyer-va d7da911
MHV-68149 Roll back default config setting
mmoyer-va ae25857
MHV-68149 Removing unnecessary test fix
mmoyer-va 0dd64b9
MHV-68149 Fixed images and DICOM download
mmoyer-va 48dc9af
Merge branch 'master' into MHV-68159-switch-to-api-gateway
mmoyer-va 5618921
Merge branch 'master' into MHV-68159-switch-to-api-gateway
mmoyer-va a88aed9
MHV-68149 Mock Flipper settings in specs
mmoyer-va 2fd7110
MHV-68159 Move functionality to before(:each) to allow mocking
mmoyer-va File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would think that the
v1
isn't necessary here because it's not used currently. Is it intentionally added here and throughout the rest of the file in the disabled flipper scenarios?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rmtolmach both the current MHV endpoints and the new API Gateway endpoints contain the
v1
pattern, although there are other differences in the path. I have tested all the endpoints (against staging) with the flag on and off to ensure that we are successfully hitting the correct resources in both scenarios.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you've tested it and it works, that sounds good.