Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more failure email template params - IVC CHAMPVA forms #21159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michaelclement
Copy link
Contributor

@michaelclement michaelclement commented Mar 7, 2025

Summary

Adds two more IVC failure email template values to the settings file.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

NA

What areas of the site does it impact?

IVC forms 10-7959a/c

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

NA

@michaelclement michaelclement changed the title Added more email template params - IVC CHAMPVA forms Added more failure email template params - IVC CHAMPVA forms Mar 7, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to update-email-parameters-ivc-champva/main/main March 7, 2025 17:45 Inactive
Copy link
Contributor

@stevenjcumming stevenjcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the Parameters are only set for prod? Is it an issue if the template ids are nil in the lower environments?

@michaelclement
Copy link
Contributor Author

Ah, thanks for catching that - I've added the staging values. For dev/sandbox it's alright if they're blank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants