feat: test Flipper feature flag in ApplicationController #21160
+32
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
art/poa-requests/spec-feature-flag/main/main
ojbucao
force-pushed
the
art/poa-requests/spec-feature-flag
branch
from
0b2a207 to
9a2ec9f
Compare
ojbucao
changed the title
•Added Flipper validation to ApplicationController spec to ensure API access is blocked when :accredited_representative_portal_pilot is disabled. •Modified tests to check that the feature flag takes priority over authentication. •Ensured existing authentication tests remain intact, validating correct behavior when the flag is enabled. •If Flipper is disabled, requests now return 403 Forbidden before checking tokens or audience validation.
ojbucao
force-pushed
the
art/poa-requests/spec-feature-flag
branch
from
9a2ec9f to
462991d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that all routes in the Accredited Representative Portal are properly gated behind the :accredited_representative_portal_pilot feature flag. If the flag is disabled, the API will immediately return 403 Forbidden, regardless of authentication.