Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10-10CG] Add claim_id to statsD metrics #21162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

coope93
Copy link
Contributor

@coope93 coope93 commented Mar 7, 2025

Summary

  • This work is behind a feature toggle (flipper): NO
  • Add a claim_id tag and value to statsD metrics in the Form1010CG::SubmissionJob. These will help us more quickly identify and link claims from monitors and the database record. The claim_id is an internal value to the database and is not pii. The value is already in the args in the param for one of the metrics, but this makes it easier to filter on in datadog.
  • 1010 Health Apps

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@coope93 coope93 changed the title add claim_id tag to 1010cg submission job statsd metrics [10-10CG] Add claim_id to statsD metrics Mar 7, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to 104367-add-context-to-1010cg-submission-job/main/main March 7, 2025 19:52 Inactive
@coope93 coope93 marked this pull request as ready for review March 7, 2025 20:18
@coope93 coope93 requested review from a team as code owners March 7, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants