Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1421: add form-1095b service tag for datadog monitoring #21165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kpethtel
Copy link
Contributor

@kpethtel kpethtel commented Mar 7, 2025

Summary

  • *This work is behind a feature toggle (flipper): NO (but these endpoints are not currently in use)
  • Adds a service tag for use on datadog. AFAIK no additional steps are necessary to make this service appear on DD.

Related issue(s)

https://github.com/department-of-veterans-affairs/va-iir/issues/1424

Testing done

I don't think this needs to be tested, but I'm open to suggestion if anyone has ideas.

Screenshots

Note: Optional

What areas of the site does it impact?

It should create a new service on DD that can be used for monitoring this feature.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link
Contributor

@khenson-oddball khenson-oddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpethtel kpethtel marked this pull request as ready for review March 7, 2025 21:20
@kpethtel kpethtel requested review from a team as code owners March 7, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants