Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-45510-add-bgs-service #21167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

stiehlrod
Copy link
Contributor

Summary

  • Adds new method to benefit claim web service.
  • Adds corresponding tests and vcr cassettes.

Related issue(s)

Testing done

  • New code is covered by unit tests

What areas of the site does it impact?

modified:   modules/claims_api/lib/bgs_service/benefit_claim_web_service.rb
new file:   modules/claims_api/spec/lib/claims_api/bgs/benefit_claim_web_service_spec.rb
new file:   spec/support/vcr_cassettes/claims_api/bgs/benefit_claim_web_service/find_bnft_claim.yml
new file:   spec/support/vcr_cassettes/claims_api/bgs/benefit_claim_web_service/find_bnft_claim_by_clmant_id.yml
new file:   spec/support/vcr_cassettes/claims_api/bgs/benefit_claim_web_service/update_bnft_claim.yml

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants