104641e - Remove champva_require_all_s3_success flipper - IVC CHAMPVA forms

[michaelclement]

Summary

This PR removes the champva_require_all_s3_success flipper that has been fully enabled in production for some months now.

Related issue(s)

• Remove flippers that have been fully enabled for over 1 month va.gov-team#104641

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
• If this work is behind a flipper:
  • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
  • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

NA

[michaelclement]

Blocked until #21319, #21320, #21324, and #21325 are merged

[github-actions]

1 Warning

⚠️

This PR changes 306 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files config/features.yml (+0/-15) modules/ivc_champva/app/controllers/ivc_champva/v1/pega_controller.rb (+2/-8) modules/ivc_champva/app/controllers/ivc_champva/v1/uploads_controller.rb (+2/-6) modules/ivc_champva/app/services/ivc_champva/attachments.rb (+3/-14) modules/ivc_champva/app/services/ivc_champva/file_uploader.rb (+2/-6) modules/ivc_champva/spec/requests/ivc_champva/v1/forms/status_updates_spec.rb (+51/-123) modules/ivc_champva/spec/requests/ivc_champva/v1/forms/uploads_spec.rb (+0/-7) modules/ivc_champva/spec/services/attachments_spec.rb (+14/-36) modules/ivc_champva/spec/services/file_uploader_spec.rb (+1/-11) modules/ivc_champva/spec/services/monitor_spec.rb (+0/-5) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger