Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-45666 Move VANotify job, save harder, and log more #21349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cilestin
Copy link
Contributor

@cilestin cilestin commented Mar 20, 2025

Summary

  • Move VANotify to after saving the POA record in PoaVBMSUpdater
  • Should let the record save successfully before trying to send email, hopefully allowing the status to move into UPDATED as expected even when the email fails.

Related issue(s)

API-45666

Testing done

  • New code is covered by unit tests

What areas of the site does it impact?

Background jobs & process order

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

@cilestin cilestin added NOT_YET Don't merge this PR w/o the authors permission claimsApi modules/claims_api labels Mar 20, 2025
@cilestin cilestin marked this pull request as ready for review March 20, 2025 02:14
@cilestin cilestin requested a review from a team as a code owner March 20, 2025 02:14
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy path is confirmed to work as expected. Recieved the email as expected, statues as expected.

Screenshot 2025-03-20 at 9 35 28 AM

Screenshot 2025-03-20 at 9 36 18 AM

  • When the VA Notify accepted job fails I also got the statues that I believe we are going for here so this looks good to me
Screenshot 2025-03-20 at 9 38 46 AM

@cilestin Once the Rubocop linting stuff gets updated I can stamp this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api lint-failure NOT_YET Don't merge this PR w/o the authors permission test-passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants