Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub the entire instance method of IAMSSOeOAuth::Configuration in the IAMSSOeOAuth::SessionManager #21357

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RachalCassity
Copy link
Member

@RachalCassity RachalCassity commented Mar 20, 2025

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

Fixing the IAMSSOeOAuth::SessionManager flakey spec by stubbing the entire IAMSSOeOAuth::Configuration instance. The configuration used to be stubbed but was taken out, I believe on accident, when fixing a dependabot issue. The error can be found in this CI run .

Related issue(s)

  • N/A

Testing done

  • N/A - spec fix

Screenshots

Note: Optional

What areas of the site does it impact?

Improving CI specs

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to iam-ssoe-oauth-spec-fix/main/main March 20, 2025 15:56 Inactive
@RachalCassity RachalCassity changed the title Mock OpenSSL cert and keys in the IAMSSOeOAuth::SessionManager spec Stub the entire instance method of IAMSSOeOAuth::Configuration in the IAMSSOeOAuth::SessionManager Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants