-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/breakers service matching #21368
Draft
acrollet
wants to merge
9
commits into
master
Choose a base branch
from
feature/breakers-service-matching
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the common client to be able to do breakers matching on service name instead of request URL. This will help avoid breakers tripping for different services that share the same host and base_path. (Most notably lighthouse)
Breakers PR: department-of-veterans-affairs/breakers#40
Slack thread: https://dsva.slack.com/archives/C0460N83Y9G/p1742325203299699
Gemfile Update:
breakers
gem to use a specific branch from the GitHub repository.Middleware Usage:
docs/setup/betamocks.md
to includeservice_name
when usingbreakers
middleware.lib/common/client/base.rb
to warn ifservice_name
is not passed tobreakers
middleware and to ensurebreakers
is the first middleware implemented.lib/common/client/configuration/base.rb
to match requests byservice_name
if available and added logging for service creation. [1] [2]Service Configuration:
service_name
method tolib/kafka/schema_registry/configuration.rb
andmodules/ivc_champva/lib/pega_api/configuration.rb
. [1] [2]lib/evss/base_service.rb
andmodules/claims_api/lib/bgs_service/local_bgs.rb
to include_breakers_service
and_request_service_name
parameters. [1] [2]lib/unified_health_data/configuration.rb
to passservice_name
tobreakers
middleware.Related issue(s)
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?