Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swagger docs for decision review endpoints #21374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kayline
Copy link
Contributor

@kayline kayline commented Mar 21, 2025

Summary

  • This work is behind a feature toggle (flipper): YES
  • (Summarize the changes that have been made to the platform)
    Update the urls for decision review endpoints in the swagger docs, to reflect the new module prefix
  • (Which team do you work for, does your team own the maintenance of this component?)
    Decision Reviews, we own the urls being documented

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
    Swagger docs still showed the old urls without the decision_reviews prefix
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
    Check swagger docs page

What areas of the site does it impact?

Swagger docs

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@kayline kayline marked this pull request as ready for review March 24, 2025 16:19
@kayline kayline requested review from a team as code owners March 24, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants