Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arf/simple-forms-duplicate-and-add-686c #21375

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

patrick-brown-oddball
Copy link
Contributor

Summary

We are adding a form upload to the Accredited Rep Portal. We are borrowing from simple forms but creating a new system for our needs. You can read more about the needs and reasoning here - https://dsva.slack.com/docs/T03FECE8V/F08GCG2AQ1H

We are releasing the app in steps. This is the first. The steps for the backend are -

  • HERE add 21-686c form to persistent attachments and form upload notification email. We will re-use these already built parts for our own app. We are starting off our application with the 21-686c form as a baseline and then we are going to add the other forms once we are done with the infrastructure
  • Make the upload tool ARP compliant - create our own controller with validations for our circumstances such as checking power of attorney for the claimant
  • Add new table arp_in_progress_forms so any reps that are also veterans don't affect their own uploads

Related issue(s)

We will eventually add a power of attorney check on submit to make sure the rep has poa for the veteran they are submitting the form for. We are starting with the 686c form and then expand out to all the forms we need

Testing done

  • New code is covered by unit tests

What areas of the site does it impact?

  • A new page at /representative_form_upload

Acceptance criteria

  • I added unit tests and integration tests for each feature

chumpy
chumpy previously approved these changes Mar 21, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to arf/simple-forms-duplicate-and-add-686c/main/main March 21, 2025 20:56 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants