-
Notifications
You must be signed in to change notification settings - Fork 73
105852 add specs for upstream failures in appointment booking flow #21377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ea1db67
add request spec for 500 response from Wellhive API
PhilipDeFraties ff4db78
remove rescue block from fetch method, was obstructing abstracted err…
PhilipDeFraties 5964ccf
revert service spec unit test to expect original exception
PhilipDeFraties 83a8c8d
update worker to rescue correct exception raised by base client
PhilipDeFraties 57f4f72
add sad path unit tests
PhilipDeFraties 73c4472
rubocop fix, stub dependency instead of subject method
PhilipDeFraties b0a5849
rubocop fix
PhilipDeFraties 6312dae
update to expect specific service exception
PhilipDeFraties 72932ac
add create draft request spec for upstream 500 error
PhilipDeFraties f60b466
remove unused error class
PhilipDeFraties 43f114d
revert expectations for raised exceptions
PhilipDeFraties 4c6753a
Merge branch 'master' into 105852_upstream_failure_testing
PhilipDeFraties ebc6e1b
update fixture to remove cookie value and fix status message
PhilipDeFraties 0479423
Merge branch 'master' into 105852_upstream_failure_testing
PhilipDeFraties File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
spec/support/vcr_cassettes/vaos/eps/get_appointment/404.yml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
56 changes: 56 additions & 0 deletions
56
spec/support/vcr_cassettes/vaos/eps/get_appointment/500.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
--- | ||
http_interactions: | ||
- request: | ||
method: get | ||
uri: https://api.wellhive.com/care-navigation/v1/appointments/qdm61cJ5?retrieveLatestDetails=true | ||
PhilipDeFraties marked this conversation as resolved.
Show resolved
Hide resolved
|
||
body: | ||
encoding: US-ASCII | ||
string: '' | ||
headers: | ||
Accept: | ||
- application/json | ||
Content-Type: | ||
- application/json | ||
User-Agent: | ||
- Vets.gov Agent | ||
Referer: | ||
- https://review-instance.va.gov | ||
X-Vamf-Jwt: | ||
- stubbed-token | ||
X-Request-Id: | ||
- '' | ||
Accept-Encoding: | ||
- gzip;q=1.0,deflate;q=0.6,identity;q=0.3 | ||
response: | ||
status: | ||
code: 500 | ||
message: Internal Server Error | ||
headers: | ||
Date: | ||
- Wed, 26 May 2021 22:47:08 GMT | ||
Content-Type: | ||
- application/json | ||
Content-Length: | ||
- '260' | ||
Server: | ||
- openresty | ||
X-Vamf-Version: | ||
- 1.5.0 | ||
B3: | ||
- edb650c5fed99511-10c51619b9c07470-1 | ||
Access-Control-Allow-Headers: | ||
- x-vamf-jwt | ||
X-Vamf-Build: | ||
- d8af5ed | ||
X-Vamf-Timestamp: | ||
- '2021-05-24T22:00:44+0000' | ||
Access-Control-Allow-Origin: | ||
- "*" | ||
Access-Control-Allow-Methods: | ||
- GET,OPTIONS | ||
Access-Control-Max-Age: | ||
- '3600' | ||
body: | ||
encoding: UTF-8 | ||
string: '{"isFault": true,"isTemporary": true,"name": "Internal Server Error"}' | ||
recorded_at: Wed, 26 May 2021 22:47:08 GMT |
51 changes: 51 additions & 0 deletions
51
spec/support/vcr_cassettes/vaos/eps/get_appointments/500_error.yml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.