Skip to content

Conversation

rmtolmach
Copy link
Contributor

Summary

This failed 4 times on master earlier today and is also failing on the production-bypass branch, which is blocking an OOB deploy.

Related issue(s)

None. Saw while on support.

Testing done

rebeccatolmach ~/git/vets-api be rspec modules/meb_api/spec/dgi/letters/service_spec.rb
...
Finished in 0.14219 seconds (files took 19.49 seconds to load)
0 examples, 0 failure

What areas of the site does it impact?

modules/meb_api/spec/dgi/letters/service_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@Copilot Copilot AI review requested due to automatic review settings October 21, 2025 20:18
@rmtolmach rmtolmach requested review from a team as code owners October 21, 2025 20:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR temporarily disables two test suites (#get_claim_letter and #get_fry_claim_letter) in the MEB API letters service spec due to intermittent VCR errors. The failures are blocking deployments on both master and production-bypass branches.

  • Skips #get_claim_letter test suite with reason 'intermittent VCR errors'
  • Skips #get_fry_claim_letter test suite with reason 'intermittent VCR errors'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant