Vebt564 - Remove 1990s Form

[alexchan-va]

Keep your PR as a Draft until it's ready for Platform review. A PR is ready for Platform review when it has a teammate approval and tests, linting, and settings checks pass CI. See these tips on how to avoid common delays in getting your PR merged.

Summary

• This work is behind a feature toggle (flipper): YES/NO no
• (Summarize the changes that have been made to the platform) remove all 1990s form references
• (If bug, how to reproduce)
• (What is the solution, why is this the solution?) remove all 1990s form references
• (Which team do you work for, does your team own the maintenance of this component?) VEBT
• (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

• Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira https://jira.devops.va.gov/browse/VEBT-564
• Link to previous change of the code/bug (if applicable)
• Link to epic if not included in ticket

Testing done

All tests still pass.

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[github-actions]

1 Warning

⚠️

This PR changes 269 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files .github/CODEOWNERS (+0/-4) app/models/education_benefits_claim.rb (+0/-4) app/models/form_profile.rb (+2/-4) app/models/form_profiles/va_1990e.rb (+0/-9) app/models/form_profiles/va_1990s.rb (+0/-48) app/models/saved_claim/education_benefits.rb (+1/-1) app/models/saved_claim/education_benefits/va_1990e.rb (+0/-23) app/models/saved_claim/education_benefits/va_1990s.rb (+0/-9) app/sidekiq/education_form/create_daily_fiscal_year_to_date_report.rb (+1/-1) app/sidekiq/education_form/create_daily_spool_files.rb (+1/-1) app/sidekiq/education_form/education_facility.rb (+2/-2) app/sidekiq/education_form/forms/va_1990e.rb (+0/-19) app/sidekiq/education_form/forms/va_1990s.rb (+0/-28) app/sidekiq/education_form/templates/1990e.erb (+0/-48) app/sidekiq/education_form/templates/1990s.erb (+0/-34) config/features.yml (+0/-7) config/form_profile_mappings/22-1990E.yml (+0/-3) config/form_profile_mappings/22-1990S.yml (+0/-12) config/settings.yml (+0/-1) config/settings/development.yml (+0/-1) config/settings/test.yml (+0/-1) lib/source_app_middleware.rb (+0/-2) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf, modules/*/spec/fixtures/*, modules/*/spec/factories/*, modules/*/spec/**/*.rb, spec/**/*.rb Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger