Conversation
Contributor
Generated by 🚫 Danger |
7c2dbf0 to
db8758f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the V2025 PDF-fill implementation for 21P-534EZ Section 6 (“Children of the Veteran Information”) behind the existing :survivors_benefits_form_2025_version_enabled feature flag, along with updated V2025 output fixtures to validate the new field mappings.
Changes:
- Implemented full Section 6 V2025
KEYmapping andexpand/child-expansion transformations. - Added/updated V2025 output fixture JSONs for section 6 scenarios (full, minimal/“off”, and 2-children cases).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
modules/survivors_benefits/lib/survivors_benefits/pdf_fill/sections/V2025/section_06.rb |
Defines V2025 Section 6 PDF field mappings and data expansion logic (SSN/date splits, child arrays, radio/checkbox conversions, custodian address parsing). |
modules/survivors_benefits/spec/lib/survivors_benefits/pdf_fill/output/V2025/21P-534EZ_section-6.json |
Expected filled-field output for a 3-child “full” Section 6 scenario in V2025. |
modules/survivors_benefits/spec/lib/survivors_benefits/pdf_fill/output/V2025/21P-534EZ_section-6_1.json |
Expected filled-field output for “unchecked/Off” child-status + negative radio scenario in V2025. |
modules/survivors_benefits/spec/lib/survivors_benefits/pdf_fill/output/V2025/21P-534EZ_section-6_2.json |
Expected filled-field output for a 2-child Section 6 scenario in V2025. |
rmtolmach
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep your PR as a Draft until it's ready for Platform review. A PR is ready for Platform review when it has a teammate approval and tests, linting, and settings checks pass CI. See these tips on how to avoid common delays in getting your PR merged.
Summary
Related issue(s)
Testing done
Screenshots
Overflow


What areas of the site does it impact?
Section 6 pdf fill and tests for the 534ez form.
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?