Skip to content

534ez add 2025 section 6#27358

Merged
dgading merged 4 commits intomasterfrom
534ez-update-2025-section-6
Apr 9, 2026
Merged

534ez add 2025 section 6#27358
dgading merged 4 commits intomasterfrom
534ez-update-2025-section-6

Conversation

@dgading
Copy link
Copy Markdown
Contributor

@dgading dgading commented Mar 27, 2026

Keep your PR as a Draft until it's ready for Platform review. A PR is ready for Platform review when it has a teammate approval and tests, linting, and settings checks pass CI. See these tips on how to avoid common delays in getting your PR merged.

Summary

  • This work is behind a feature toggle (flipper): YES (:survivors_benefits_form_2025_version_enabled )
  • Summary This PR adds section 6 of 12 to the 534ez's 2025 pdf version update. It includes the relevant 2025 test updates to match the new keys.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Manually tested with pdf fill locally

Screenshots

Screenshot 2026-04-06 at 3 21 18 PM

Overflow
Screenshot 2026-04-06 at 3 24 44 PM
Screenshot 2026-04-06 at 3 24 50 PM

What areas of the site does it impact?

Section 6 pdf fill and tests for the 534ez form.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@github-actions
Copy link
Copy Markdown
Contributor

1 Warning
⚠️ This PR changes 372 lines of code (not counting whitespace/newlines, comments, or test files).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/survivors_benefits/lib/survivors_benefits/pdf_fill/sections/V2025/section_06.rb (+371/-1)

Note: We exclude files matching the following when considering PR size:

*.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf, modules/*/spec/fixtures/*, modules/*/spec/factories/*, modules/*/spec/**/*.rb, spec/**/*.rb, modules/*/docs/**/*.yaml, modules/*/docs/**/*.yml, modules/*/app/docs/**/*.yaml, modules/*/app/docs/**/*.yml

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@dgading dgading force-pushed the 534ez-update-2025-section-6 branch from 7c2dbf0 to db8758f Compare April 3, 2026 20:30
Copy link
Copy Markdown
Contributor

@euler-room euler-room left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@dgading dgading marked this pull request as ready for review April 7, 2026 18:53
@dgading dgading requested review from a team as code owners April 7, 2026 18:53
Copilot AI review requested due to automatic review settings April 7, 2026 18:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the V2025 PDF-fill implementation for 21P-534EZ Section 6 (“Children of the Veteran Information”) behind the existing :survivors_benefits_form_2025_version_enabled feature flag, along with updated V2025 output fixtures to validate the new field mappings.

Changes:

  • Implemented full Section 6 V2025 KEY mapping and expand/child-expansion transformations.
  • Added/updated V2025 output fixture JSONs for section 6 scenarios (full, minimal/“off”, and 2-children cases).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
modules/survivors_benefits/lib/survivors_benefits/pdf_fill/sections/V2025/section_06.rb Defines V2025 Section 6 PDF field mappings and data expansion logic (SSN/date splits, child arrays, radio/checkbox conversions, custodian address parsing).
modules/survivors_benefits/spec/lib/survivors_benefits/pdf_fill/output/V2025/21P-534EZ_section-6.json Expected filled-field output for a 3-child “full” Section 6 scenario in V2025.
modules/survivors_benefits/spec/lib/survivors_benefits/pdf_fill/output/V2025/21P-534EZ_section-6_1.json Expected filled-field output for “unchecked/Off” child-status + negative radio scenario in V2025.
modules/survivors_benefits/spec/lib/survivors_benefits/pdf_fill/output/V2025/21P-534EZ_section-6_2.json Expected filled-field output for a 2-child Section 6 scenario in V2025.

@dgading dgading merged commit 8aed244 into master Apr 9, 2026
58 of 59 checks passed
@dgading dgading deleted the 534ez-update-2025-section-6 branch April 9, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants