Skip to content

534ez add 2025 section 9#27362

Merged
dgading merged 6 commits intomasterfrom
534ez-update-2025-section-9
Apr 9, 2026
Merged

534ez add 2025 section 9#27362
dgading merged 6 commits intomasterfrom
534ez-update-2025-section-9

Conversation

@dgading
Copy link
Copy Markdown
Contributor

@dgading dgading commented Mar 27, 2026

Keep your PR as a Draft until it's ready for Platform review. A PR is ready for Platform review when it has a teammate approval and tests, linting, and settings checks pass CI. See these tips on how to avoid common delays in getting your PR merged.

Summary

  • This work is behind a feature toggle (flipper): YES (:survivors_benefits_form_2025_version_enabled )
  • Summary This PR adds section 9 of 12 to the 534ez's 2025 pdf version update. It includes the relevant 2025 test updates to match the new keys.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Manually tested locally with pdf fill

Screenshots

Screenshot 2026-04-07 at 11 58 13 AM Screenshot 2026-04-07 at 11 58 24 AM

What areas of the site does it impact?

Section 9 of 534ez

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@dgading dgading force-pushed the 534ez-update-2025-section-9 branch from b618156 to f7d691b Compare April 6, 2026 21:16
euler-room
euler-room previously approved these changes Apr 7, 2026
Copy link
Copy Markdown
Contributor

@euler-room euler-room left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@dgading dgading marked this pull request as ready for review April 7, 2026 18:53
@dgading dgading requested review from a team as code owners April 7, 2026 18:53
Copilot AI review requested due to automatic review settings April 7, 2026 18:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds SurvivorsBenefits 21P-534EZ V2025 PDF-fill support for Section 9 (Income and Assets) and updates the corresponding V2025 output fixtures used by the existing PDF merge/fixture spec.

Changes:

  • Implement V2025 Section9 KEY mappings and expand transformations for Section 9 fields.
  • Add/refresh V2025 section-9 output fixture JSON files used by va21p534ez_spec.
  • Introduce income-entry expansion logic for up to four income entries in V2025.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
modules/survivors_benefits/lib/survivors_benefits/pdf_fill/sections/V2025/section_09.rb Adds V2025 Section 9 field mappings and expansion logic for checkboxes and income entries.
modules/survivors_benefits/spec/lib/survivors_benefits/pdf_fill/output/V2025/21P-534EZ_section-9.json Updates expected filled-field output for V2025 section 9 base fixture.
modules/survivors_benefits/spec/lib/survivors_benefits/pdf_fill/output/V2025/21P-534EZ_section-9_1.json Updates expected output for V2025 section 9 variant fixture.
modules/survivors_benefits/spec/lib/survivors_benefits/pdf_fill/output/V2025/21P-534EZ_section-9_2.json Updates expected output for V2025 section 9 variant fixture.
modules/survivors_benefits/spec/lib/survivors_benefits/pdf_fill/output/V2025/21P-534EZ_section-9_3.json Updates expected output for V2025 section 9 variant fixture.
modules/survivors_benefits/spec/lib/survivors_benefits/pdf_fill/output/V2025/21P-534EZ_section-9_4.json Updates expected output for V2025 section 9 variant fixture.

@dgading dgading merged commit b40cba6 into master Apr 9, 2026
42 checks passed
@dgading dgading deleted the 534ez-update-2025-section-9 branch April 9, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants