FDF 133550 forms service class separation#27391
Merged
wayne-weibel merged 3 commits intomasterfrom Mar 31, 2026
Merged
Conversation
wayne-weibel
commented
Mar 27, 2026
Comment on lines
-30
to
-32
| rescue => e | ||
| Rails.logger.error('Digital Forms API - unexpected error', { message: e.message }) | ||
| render json: { error: 'Internal server error' }, status: :internal_server_error |
Contributor
Author
There was a problem hiding this comment.
Any additional errors are captured by ApplicationsController, so this is unneeded
app/controllers/application_controller.rb
app/controllers/concerns/exception_handling.rb
ARPerry87
approved these changes
Mar 30, 2026
Contributor
ARPerry87
left a comment
ARPerry87
left a comment
There was a problem hiding this comment.
Nice decoupling. Also like to see how modular everything is now. Looks great to me!
stiehlrod
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
separate forms service into a schema and template service - improve code clarity and monitoring
Related issue(s)
[FDF] Forms service class separation
Testing done
made requests from ruby console in local environment
What areas of the site does it impact?
fully digital forms
Acceptance criteria