Skip to content

add feature flag for automate-mst-consent#27566

Merged
janechodance merged 2 commits intomasterfrom
137308-526-0781-create-feature-flag-for-automate-MST-consent
Apr 6, 2026
Merged

add feature flag for automate-mst-consent#27566
janechodance merged 2 commits intomasterfrom
137308-526-0781-create-feature-flag-for-automate-MST-consent

Conversation

@janechodance
Copy link
Copy Markdown
Contributor

@janechodance janechodance commented Apr 3, 2026

Keep your PR as a Draft until it's ready for Platform review. A PR is ready for Platform review when it has a teammate approval and tests, linting, and settings checks pass CI. See these tips on how to avoid common delays in getting your PR merged.

Summary

Added the form526_0781_automate_mst_consent feature flag to config/features.yml to control the automatically sending mst consent

Related issue(s)

department-of-veterans-affairs/va.gov-team#137308

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@janechodance janechodance changed the title add feature flag add feature flag for automate-mst-consent Apr 3, 2026
@LinnJS LinnJS added disability-benefits Disability Benefits Crew disability-benefits-pathways-team Disability Benefits Crew - Alternative Pathways Team labels Apr 6, 2026
@janechodance janechodance marked this pull request as ready for review April 6, 2026 15:20
@janechodance janechodance requested a review from a team as a code owner April 6, 2026 15:20
Copilot AI review requested due to automatic review settings April 6, 2026 15:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Flipper feature toggle to vets-api to gate automated MST-consent behavior associated with the Form 526 / Form 0781 submission flow.

Changes:

  • Added form526_0781_automate_mst_consent feature flag entry in config/features.yml.
  • Configured the flag as actor_type: user and enabled it in development by default.

Comment thread config/features.yml
enable_in_development: true
form526_0781_automate_mst_consent:
actor_type: user
description: Enables mst consent to send automatically when the 0781 form is submitted in the 526 flow, when the veteran given consent
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description text has grammatical issues and inconsistent capitalization ("mst" vs "MST"), which makes the feature flag intent harder to understand. Consider rephrasing to something like: "Enables MST consent to be sent automatically when Form 0781 is submitted as part of the Form 526 flow, if the veteran has given consent."

Suggested change
description: Enables mst consent to send automatically when the 0781 form is submitted in the 526 flow, when the veteran given consent
description: Enables MST consent to be sent automatically when Form 0781 is submitted as part of the Form 526 flow, if the veteran has given consent.

Copilot uses AI. Check for mistakes.
@janechodance janechodance merged commit 30666f3 into master Apr 6, 2026
42 checks passed
@janechodance janechodance deleted the 137308-526-0781-create-feature-flag-for-automate-MST-consent branch April 6, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disability-benefits Disability Benefits Crew disability-benefits-pathways-team Disability Benefits Crew - Alternative Pathways Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(526-0781): Create feature flag for automate MST consent

4 participants