Skip to content

Clarify Slack messaging for low code coverage #27586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmtolmach wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

Clarify Slack messaging for low code coverage #27586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/code_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,13 +711,17 @@ jobs:
"type": "header",
"text": {
"type": "plain_text",
"text": ":warning: Warning: Vets-API Coverage Below Target",
"text": ":warning: Warning: Vets-API Coverage Below 93%",
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning header now highlights the 93% threshold, but the block still includes a field labeled ":dart: Required Minimum: 90%" (deployment block threshold). That combination can read as internally inconsistent (is the requirement 93% or 90%?). Consider renaming the 90% field to something explicit like “Deployment block threshold” / “Minimum to avoid deploy block”, and optionally adding a separate “Warning threshold: 93%” line for clarity.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

@rmtolmach rmtolmach Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the fact that this is a "warning" makes it clear. But I'm open to other wording.

"emoji": true
}
},
{
"type": "section",
"fields": [
{
"type": "mrkdwn",
"text": "_If coverage dips below 90%, CI, including deployments, will be blocked._"
},
{
"type": "mrkdwn",
Comment on lines 720 to 726
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This explanatory sentence is added as a "field" in a section that uses "fields" (2-column layout). In Slack Block Kit, fields will render in columns, so this note may appear squeezed into the left column next to “Current Coverage”, reducing readability. Consider making it its own section with a "text" value (full-width) above the fields list.

Suggested change
"fields": [
{
"type": "mrkdwn",
"text": "_If coverage dips below 90%, CI, including deployments, will be blocked._"
},
{
"type": "mrkdwn",
"text": {
"type": "mrkdwn",
"text": "_If coverage dips below 90%, CI, including deployments, will be blocked._"
}
},
{
"type": "section",
"fields": [
{
"type": "mrkdwn",

Copilot uses AI. Check for mistakes.
"text": ":chart_with_downwards_trend: *Current Coverage*: ${{ steps.coverage.outputs.percent }}%"
Expand Down
Loading