Skip to content

VaNotify - Migrate app/models/saved_claim/education_benefits.rb to use v2 email job#27588

Merged
nathanbwright merged 3 commits intomasterfrom
vanotify-2027-migrate-job
Apr 7, 2026
Merged

VaNotify - Migrate app/models/saved_claim/education_benefits.rb to use v2 email job#27588
nathanbwright merged 3 commits intomasterfrom
vanotify-2027-migrate-job

Conversation

@nathanbwright
Copy link
Copy Markdown
Contributor

@nathanbwright nathanbwright commented Apr 6, 2026

Keep your PR as a Draft until it's ready for Platform review. A PR is ready for Platform review when it has a teammate approval and tests, linting, and settings checks pass CI. See these tips on how to avoid common delays in getting your PR merged.

Summary

  • *This work is behind a feature toggle (flipper): YES
  • (Summarize the changes that have been made to the platform) Migrates to use VANotify::V2::QueueEmailJob
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution?)
  • (Which team do you work for, does your team own the maintenance of this component?)
  • (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link
Copy Markdown
Contributor

@MarchandMD MarchandMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanbwright nathanbwright marked this pull request as ready for review April 6, 2026 18:36
@nathanbwright nathanbwright requested review from a team as code owners April 6, 2026 18:36
@nathanbwright nathanbwright merged commit 80270a4 into master Apr 7, 2026
44 of 45 checks passed
@nathanbwright nathanbwright deleted the vanotify-2027-migrate-job branch April 7, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants