Skip to content

FDF 138477 veteran information#27589

Merged
wayne-weibel merged 1 commit intomasterfrom
fdf-138477-vertern-information
Apr 6, 2026
Merged

FDF 138477 veteran information#27589
wayne-weibel merged 1 commit intomasterfrom
fdf-138477-vertern-information

Conversation

@wayne-weibel
Copy link
Copy Markdown
Contributor

Summary

  • This work is behind a feature toggle (flipper): YES
    veteran information in the submission was missing due to being overwritten

Related issue(s)

[FDF] veteran_information overwritten

Testing done

  • New code is covered by unit tests
    perform actions in local terminal and on staging console

What areas of the site does it impact?

dependents fdf

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)

Copy link
Copy Markdown
Contributor

@davidbecker6081 davidbecker6081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@wayne-weibel wayne-weibel marked this pull request as ready for review April 6, 2026 18:12
@wayne-weibel wayne-weibel requested review from a team as code owners April 6, 2026 18:12
@wayne-weibel wayne-weibel merged commit 5078399 into master Apr 6, 2026
43 of 44 checks passed
@wayne-weibel wayne-weibel deleted the fdf-138477-vertern-information branch April 6, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants