Fix Metrics/ModuleLength on FhirHelpers (102/100)#27620
Merged
Conversation
mdewey
approved these changes
Apr 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a RuboCop CI failure by disabling Metrics/ModuleLength for the UnifiedHealthData::Adapters::FhirHelpers module, which has grown beyond the configured line threshold as shared FHIR utility methods were added.
Changes:
- Adds an inline
# rubocop:disable Metrics/ModuleLengthannotation to theFhirHelpersmodule declaration.
stiehlrod
approved these changes
Apr 7, 2026
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rubocop:disable Metrics/ModuleLengthtoFhirHelpersmodule which hit 102/100 lines after the imaging refresh job merge added shared FHIR utility methods.Related issue(s)
Testing done
bundle exec rubocop lib/unified_health_data/adapters/fhir_helpers.rbpasses with 0 offensesWhat areas of the site does it impact?
No functional change. Rubocop annotation only on a shared FHIR utility module under
lib/unified_health_data/adapters/.Acceptance criteria