Skip to content

Fix Metrics/ModuleLength on FhirHelpers (102/100)#27620

Merged
batemapf merged 1 commit intomasterfrom
fix/fhir-helpers-module-length
Apr 7, 2026
Merged

Fix Metrics/ModuleLength on FhirHelpers (102/100)#27620
batemapf merged 1 commit intomasterfrom
fix/fhir-helpers-module-length

Conversation

@batemapf
Copy link
Copy Markdown
Contributor

@batemapf batemapf commented Apr 7, 2026

Summary

  • This work is behind a feature toggle (flipper): NO
  • Adds rubocop:disable Metrics/ModuleLength to FhirHelpers module which hit 102/100 lines after the imaging refresh job merge added shared FHIR utility methods.
  • This is a shared utility module that naturally grows as new FHIR adapters are added — a hard line cap would just force artificial splits.
  • Team: MHV Medical Records (My HealtheVet on VA.gov)

Related issue(s)

Testing done

  • No new code — rubocop-only fix
  • bundle exec rubocop lib/unified_health_data/adapters/fhir_helpers.rb passes with 0 offenses

What areas of the site does it impact?

No functional change. Rubocop annotation only on a shared FHIR utility module under lib/unified_health_data/adapters/.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@batemapf batemapf marked this pull request as ready for review April 7, 2026 14:49
@batemapf batemapf requested review from a team as code owners April 7, 2026 14:49
Copilot AI review requested due to automatic review settings April 7, 2026 14:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a RuboCop CI failure by disabling Metrics/ModuleLength for the UnifiedHealthData::Adapters::FhirHelpers module, which has grown beyond the configured line threshold as shared FHIR utility methods were added.

Changes:

  • Adds an inline # rubocop:disable Metrics/ModuleLength annotation to the FhirHelpers module declaration.

@batemapf batemapf enabled auto-merge (squash) April 7, 2026 14:52
@batemapf batemapf merged commit 4606d68 into master Apr 7, 2026
46 of 47 checks passed
@batemapf batemapf deleted the fix/fhir-helpers-module-length branch April 7, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants