Conversation
There was a problem hiding this comment.
Pull request overview
Updates the PDF-fill implementation for VA Form 22-10272 to match a redesigned PDF, including updated field mappings and new formatting behavior.
Changes:
- Refactors 22-10272 field mapping (
KEY) and merge helpers to align with the redesigned PDF (address structure, benefit program checkboxes, VA file number formatting). - Updates/extends RSpec coverage for the 22-10272 merge behavior and adjusts fixtures used by education benefits claims.
- Adds an overflow extras PDF fixture for 22-10272.
Reviewed changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
lib/pdf_fill/forms/va2210272.rb |
Updates field mapping + merge/format helpers for the redesigned 22-10272 PDF (checkbox benefit program, address flattening, VA file number formatting). |
spec/lib/pdf_fill/forms/va2210272_spec.rb |
Updates expectations for the new address mapping and adds VA file number formatting scenarios. |
spec/fixtures/pdf_fill/22-10272/overflow_extras.pdf |
Adds expected overflow-extras PDF fixture for 22-10272. |
spec/fixtures/education_benefits_claims/10272/minimal.json |
Updates fixture to use chapter-based vaBenefitProgram value. |
lib/pdf_fill/forms/va220810.rb |
Small refactor to compute append_payee_number inside format_va_file_number. |
|
@jefftmarks can you take a look at Copilot's comments? |
Hi @rmtolmach all changes made -- thank you! |
| }, | ||
| 'chapter35' => { | ||
| key: 'chapter35', | ||
| question_text: 'Survivor\'s and Dependents\' Educational Assistance Program (DEA) (Chapter 35)' |
There was a problem hiding this comment.
I think this isn't quite right still.
This page: https://www.va.gov/family-and-caregiver-benefits/education-and-careers/dependents-education-assistance/rates/ says "Survivors’ and Dependents’ Educational Assistance (DEA)" but this line will show up as:
Survivor's and Dependents'
There was a problem hiding this comment.
@rmtolmach oh geez I apologize. My brain was in fine form last week. Typo fixed and changes pushed
rmtolmach
added
the
Changes Requested
…-veterans-affairs/vets-api into VEBT-5146/update-pdf-10272
* tentative form updates * update form 0810 * revert spec change * typos * spec coverage * typo
Summary
Related issue(s)