VaNotify - Migrate representation_management next_steps_email_controller.rb to use v2 email job

[nathanbwright]

Keep your PR as a Draft until it's ready for Platform review. A PR is ready for Platform review when it has a teammate approval and tests, linting, and settings checks pass CI. See these tips on how to avoid common delays in getting your PR merged.

Summary

• *This work is behind a feature toggle (flipper): YES
• (Summarize the changes that have been made to the platform) Migrates to use VANotify::V2::QueueEmailJob.
• (If bug, how to reproduce)
• (What is the solution, why is this the solution?)
• (Which team do you work for, does your team own the maintenance of this component?)
• (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

• https://va.ghe.com/software/vanotify-team/issues/2044

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
• If this work is behind a flipper:
  • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
  • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[Copilot]

Pull request overview

Migrates RepresentationManagement::V0::NextStepsEmailController to optionally enqueue emails via VANotify::V2::QueueEmailJob behind a new Flipper flag, while retaining the existing VANotify::EmailJob path when the flag is off.

Changes:

• Add va_notify_v2_next_steps_email feature flag.
• Update the controller to enqueue via VANotify v2 when the flag is enabled.
• Expand request specs to cover Flipper enabled/disabled behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
modules/representation_management/app/controllers/representation_management/v0/next_steps_email_controller.rb	Adds Flipper-gated v2 enqueue path and extracts enqueue logic into a private method.
modules/representation_management/spec/requests/v0/next_steps_email_spec.rb	Adds Flipper stubbing and new contexts for v1 vs v2 job assertions.
config/features.yml	Defines new va_notify_v2_next_steps_email Flipper flag.

[rmtolmach]

@nathanbwright can you take a look at Copilot's comments?