Skip to content

better pdf stamp for education benefits submissions#27802

Merged
thomaskrenzke merged 2 commits intomasterfrom
edu-pdf-stamper-update
Apr 17, 2026
Merged

better pdf stamp for education benefits submissions#27802
thomaskrenzke merged 2 commits intomasterfrom
edu-pdf-stamper-update

Conversation

@thomaskrenzke
Copy link
Copy Markdown
Contributor

Summary

Per the signature guidelines, the stamp added to pdfs that are submitted via the benefits intake api needs to include a little more info than just 'submitted on va.gov'. This PR updates the stamp text to bring it into compliance.

Related issue(s)

  • Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira
  • Link to previous change of the code/bug (if applicable)
  • Link to epic if not included in ticket

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@thomaskrenzke thomaskrenzke marked this pull request as ready for review April 16, 2026 18:19
@thomaskrenzke thomaskrenzke requested review from a team as code owners April 16, 2026 18:19
@thomaskrenzke thomaskrenzke merged commit fe00a37 into master Apr 17, 2026
42 of 43 checks passed
@thomaskrenzke thomaskrenzke deleted the edu-pdf-stamper-update branch April 17, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants