Skip to content

Ask VA | Updating regex for inquiry ID to be more future-proof #27805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerekshoe merged 4 commits into from
Apr 17, 2026
+7 −6
Merged

Ask VA | Updating regex for inquiry ID to be more future-proof #27805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b1a7b7
Updating regex for inquiry ID to accept 5 or more digits
jerekshoe Apr 16, 2026
ba148e1
Updating specs
jerekshoe Apr 16, 2026
db2887c
Capping at 10 digits
jerekshoe Apr 16, 2026
3ca6b14
Removing typo
jerekshoe Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions modules/ask_va_api/app/controllers/ask_va_api/v0/inquiries_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,13 @@ def require_loa3!
raise Common::Exceptions::Unauthorized unless current_user&.loa&.fetch(:current, nil) == 3
end

INQUIRY_ID_FORMAT = /\AA-[0-9]{8}-[0-9]{6,7}\z/
INQUIRY_ID_FORMAT = /\AA-[0-9]{8}-[0-9]{5,10}\z/

# Validates that params[:id] follows the known inquiry ID format "A-YYYYMMDD-NNNNNN".
# Validates that params[:id] follows the known inquiry ID format "A-<8-digit date>-<5-10 digit number>".
def validate_inquiry_id_format
unless params[:id].match?(INQUIRY_ID_FORMAT)
render json: { error: 'Invalid inquiry ID format. Expected format: A-YYYYMMDD-NNNNNN.' }, status: :bad_request
end
msg = 'Invalid inquiry ID format. Expected: A-<8-digit date>-<5-10 digit number> (e.g., A-20260416-1234567).'

render json: { error: msg }, status: :bad_request unless params[:id].match?(INQUIRY_ID_FORMAT)
end

class InvalidAttachmentError < StandardError; end
Expand Down
3 changes: 2 additions & 1 deletion modules/ask_va_api/spec/requests/ask_va_api/v0/inquiries_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,8 @@
end

context 'when the id format is invalid' do
%w[invalid 12345 A-1234567-123456 A-12345678-12345 A-12345678-12345678 A12345678123456].each do |bad_id|
%w[invalid 12345 A-1234567-123456 A-12345678-1234 A-12345678-12345678901 A-12345678-12L4567
A12345678123456].each do |bad_id|
it "returns bad_request for '#{bad_id}'" do
get "/ask_va_api/v0/inquiries/#{bad_id}/status"
expect(response).to have_http_status(:bad_request)
Expand Down
Loading