vets-api/v0.0.1424
Release 0.0.1424 ami-0479438632cf8d1ca
34cfaa5 Vfep 571 - add tests for emailing spool files on staging and put contents in body of email instead of attaching (#12542)
-
email spool files staging
-
fix staging spool email settings
-
fix rubocop errors
-
rubocop errors
-
Add test coverage
-
fix tests and put contents inline in body instead of attachment
Co-authored-by: nfstern02 [email protected]
Co-authored-by: nfstern02 [email protected]
df9897b 56995 Strip dashes from valid BGS file numbers and log invalid SSNs and file numbers. (#12530)
We have been getting errors on BGS's vnp_person_create endpoint because the file number and SSN that we send over do not match. We get our file numbers from BGS and get our SSNs from MPI or another VA.gov identity provider. A mismatch may exist because MPI or BGS have the wrong SSN or file number, because BGS has an invalid file number, or because BGS has a valid file number that is incorrectly formatted.
Where MPI or BGS have the wrong file number, or where BGS has an invalid file number, all we can do is log and report the mismatches to them so they can fix the issue. Where BGS returns a valid file number that is incorrectly formatted (i.e. contains dashes and digits, instead of just digits) we can simply reformat the SSN (i.e. remove the dashes) before submitting it to BGS along with the file number. These are the aims of this PR. See the code comments for more detail.
94f361d Update danger to use actions/checkout@v3 (#12507)
154d483 [56749] Combine FSR reasons for user facing PDF (#12546)
-
Aggregate FSR reasons for general purpose PDF
-
Add exist check for debts in map