This repository is currently being migrated. It's locked while the migration is in progress.
-
Notifications
You must be signed in to change notification settings - Fork 87
Adding code usage links to point to Storybook #6149
Open
jeana-adhoc
wants to merge
16
commits into
main
Choose a base branch
from
6136-table-widths
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6aaa684
update code usage links
jeana-adhoc c938700
Title case component names
jeana-adhoc bcaddb3
Copilot fixes
jeana-adhoc c0a0298
More copilot fixes
jeana-adhoc b062956
More copilot fixes
jeana-adhoc 97964ca
Update template guidance
jeana-adhoc 5310ad5
Merge branch 'main' into 6136-table-widths
jeana-adhoc 7a74c9a
fix findings from PR reviewers
jeana-adhoc 94144fa
Refactor code usage to be more DRY
jeana-adhoc 7862794
Cleanup
jeana-adhoc 9623319
revert changes to lower the edit count to review
jeana-adhoc 210b77f
Merge branch 'main' into 6136-table-widths
jeana-adhoc 8833c91
fixes bad links to storybook
jeana-adhoc 5e13763
remove doctype
jeana-adhoc 3349ab2
inconsisent naming is making url prediction hard
jeana-adhoc 858dfbf
inconsisent naming is making url prediction hard
jeana-adhoc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,15 @@ | ||
| --- | ||
| layout: component | ||
| sub_section: Back to top | ||
| title: "Back to top" | ||
| sub_section: Back to Top | ||
| title: "Back to Top" | ||
| figma-link-web: https://www.figma.com/file/JDFpGLIojfuQwANXScQjqe/VADS-Component-Example-Library?type=design&node-id=1110%3A4128&mode=design&t=vNilCSI60pQBiKkM-1 | ||
| intro-text: "The Back to top component is a shortcut that allows the user to quickly navigate to the top of a long page of content." | ||
| intro-text: "The Back to Top component is a shortcut that allows the user to quickly navigate to the top of a long page of content." | ||
| web-component: va-back-to-top | ||
| web: true | ||
| mobile-app: false | ||
| anchors: | ||
| - anchor: Examples | ||
| - anchor: Usage | ||
| - anchor: Code usage | ||
| - anchor: Accessibility considerations | ||
| --- | ||
|
|
||
|
|
@@ -22,7 +21,7 @@ anchors: | |
|
|
||
| ## Usage | ||
|
|
||
| * On large and medium screens, the Back to top component will have the label, “Back to top” with an arrow icon to the left of the label. On small screens, the Back to top component will only have the arrow icon. Use one Back to top component per page. | ||
| * On large and medium screens, the Back to Top component will have the label, “Back to Top” with an arrow icon to the left of the label. On small screens, the Back to top component will only have the arrow icon. Use one Back to top component per page. | ||
|
|
||
| ### When to use Back to top | ||
|
|
||
|
|
@@ -44,7 +43,6 @@ anchors: | |
| * The Back to top component stays fixed in the lower right edge of the main content area when the user reaches the bottom of the page. | ||
| * Clicking Back to top takes the user to the top of the page. | ||
|
|
||
| {% include component-docs.html component_name=page.web-component %} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Question When there are no component props, we exclude the "Code usage" section?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. typically - but you are right to call this out. I left it in for va-tag, I should leave it in for this one too. |
||
|
|
||
| ## Accessibility considerations | ||
|
jeana-adhoc marked this conversation as resolved.
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.