This repository is currently being migrated. It's locked while the migration is in progress.
Add JSON Schema for VA Form 22-1999#1169
Draft
tarratsco wants to merge 7 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New schema — VA Form 22-1999
Summary
This PR introduces a new JSON Schema (Draft 04) for VA Form 22-1999 — Enrollment Certification, used by School Certifying Officials (SCOs) to certify student enrollment for GI Bill education benefits.
The schema covers the following form sections:
scoVerification) — confirms the certifying official's attestationcertificationTypeInfo) — captures the type of enrollment certification being submittedstudentInformation) — identifies the student beneficiaryinstitutionInformation) — identifies the school or training facility, with a sharedaddressdefinition requiringstreet,city,state, andpostalCodeprogramInformation) — describes the educational programenrollmentPeriod) — specifies the term or date range being certifiedcreditHours) — records the student's enrolled credit loadcertifyingOfficial) — captures signature and identity of the SCO submitting the formKey patterns include:
additionalProperties: falseenforced at the root and on the sharedaddressdefinition to prevent undeclared fieldsrequired, ensuring complete submissionsaddressdefinition with optionalstreet2field and string length constraints (minLength: 1,maxLength: 100)Files
src/schemas/22-1999-schema.jsonNotes for reviewer
package.jsonbackend-review-groupas a revieweraddressdefinition enforcesadditionalProperties: false— confirm this aligns with any address formats used in vets-api or vets-website for related education formsrequired; confirm with the form owner whether any sections (e.g.,certificationTypeInfo) should be conditionally required based on submission contextstreet2is intentionally optional within theaddressdefinition — verify this is consistent with how other education benefit schemas handle optional address linesPull Requests to update the schema in related repositories