This repository is currently being migrated. It's locked while the migration is in progress.
Add JSON Schema for VA Form 26-1805#1174
Draft
tarratsco wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New schema — VA Form 26-1805
Summary
This PR adds a new JSON Schema for VA Form 26-1805 (Appraisal Report — Real Estate), targeting the
draft-04specification. The schema is structured as a single root object withadditionalProperties: falseand includes shared definitions for reuse across the form.Key schema details include:
fullNamedefinition: Captures veteran or claimant name withfirst(max 30 chars),middle(single character, nullable), andlast(max 40 chars) fields. All name fields are pattern-validated to allow only alphabetic characters and hyphens.firstandlastare required.addressdefinition: Models a standard mailing address with astreetfield (max 100 chars), consistent with VA address patterns used across other form schemas in this repository.buildDefinitionReferencehelper to generate$refpointers, keeping field declarations DRY and consistent.maxLengthconstraints and regexpatternvalidation to enforce data integrity at the schema level.Files
src/schemas/26-1805/schema.jsNotes for reviewer
package.jsonbackend-review-groupas a reviewermiddlename field usestype: ['string', 'null']to allow explicit null values — confirm this aligns with the downstream vets-api serializer expectations.addressdefinition appears to be truncated in the artifact summary; please verify that all expected address subfields (e.g.,city,state,postalCode) are present in the committed file.buildDefinitionReferenceis scoped locally to this schema file and is not expected to be a shared utility exported elsewhere in the repo.Pull Requests to update the schema in related repositories