Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

Add JSON Schema for VA Form 26-1805#1174

Draft
tarratsco wants to merge 1 commit into
masterfrom
optimus/26-1805-schema
Draft

Add JSON Schema for VA Form 26-1805#1174
tarratsco wants to merge 1 commit into
masterfrom
optimus/26-1805-schema

Conversation

@tarratsco
Copy link
Copy Markdown
Contributor

⚠️ AI-Generated PR — This pull request was automatically generated by Optimus. All code requires human review and testing before merging.

New schema — VA Form 26-1805

Summary

This PR adds a new JSON Schema for VA Form 26-1805 (Appraisal Report — Real Estate), targeting the draft-04 specification. The schema is structured as a single root object with additionalProperties: false and includes shared definitions for reuse across the form.

Key schema details include:

  • fullName definition: Captures veteran or claimant name with first (max 30 chars), middle (single character, nullable), and last (max 40 chars) fields. All name fields are pattern-validated to allow only alphabetic characters and hyphens. first and last are required.
  • address definition: Models a standard mailing address with a street field (max 100 chars), consistent with VA address patterns used across other form schemas in this repository.
  • Definition references: Uses a buildDefinitionReference helper to generate $ref pointers, keeping field declarations DRY and consistent.
  • Strict validation: All string fields include both maxLength constraints and regex pattern validation to enforce data integrity at the schema level.

Files

  • src/schemas/26-1805/schema.js

Notes for reviewer

  • Please ensure you have incremented the version in package.json
  • Please add backend-review-group as a reviewer
  • The middle name field uses type: ['string', 'null'] to allow explicit null values — confirm this aligns with the downstream vets-api serializer expectations.
  • The address definition appears to be truncated in the artifact summary; please verify that all expected address subfields (e.g., city, state, postalCode) are present in the committed file.
  • Confirm that buildDefinitionReference is scoped locally to this schema file and is not expected to be a shared utility exported elsewhere in the repo.
  • VA Form 26-1805 is associated with real property appraisal workflows — ensure any appraiser-specific fields (e.g., license number, certification) are captured if required by the paper form.

Pull Requests to update the schema in related repositories

  • vets-api: pending
  • vets-website: pending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant