This repository is currently being migrated. It's locked while the migration is in progress.
Add JSON Schema for VA Form 10-0137#1176
Draft
tarratsco wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New schema — VA Form 10-0137
Summary
This PR introduces a new JSON Schema for VA Form 10-0137 (VA Advance Directive / Living Will and Durable Power of Attorney for Health Care). The schema is defined under
src/schemas/10-0137/schema.jsand covers the core data structures required for the form.Key schema characteristics include:
fullNamedefinition: Capturesfirst,middle, andlastname fields with string length constraints (minLength/maxLength) and a pattern restricting input to alphabetic characters, hyphens, apostrophes, and spaces.firstandlastare required;middleis optional and nullable (type: ['string', 'null']).addressdefinition: Structured address object withstreetandcityfields (additional fields likely follow in the full schema). Fields enforce minimum and maximum length constraints.buildDefinitionReferencehelper is used to generate$refpointers to shared definitions, following a consistent pattern for schema composition.$schema: 'http://json-schema.org/draft-04/schema#') withadditionalProperties: falseat the root level to enforce strict property validation.Files
src/schemas/10-0137/schema.jsNotes for reviewer
package.jsonbackend-review-groupas a reviewermiddlename field uses a union type (['string', 'null']) to explicitly allow null values — confirm this aligns with how the frontend and backend handle optional name components.additionalProperties: falseis set at the root level; verify that all expected top-level properties are explicitly declared to avoid unintended validation failures.addressdefinition and any remaining definitions (e.g., phone, date, healthcare agent fields) to confirm completeness and correctness before merging.$reftargets used viabuildDefinitionReferenceare fully defined within thedefinitionsblock.Pull Requests to update the schema in related repositories