Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

Add JSON Schema for VA Form 26-8923#1177

Draft
tarratsco wants to merge 1 commit into
masterfrom
optimus/26-8923-schema-20260423T201549Z-f02b
Draft

Add JSON Schema for VA Form 26-8923#1177
tarratsco wants to merge 1 commit into
masterfrom
optimus/26-8923-schema-20260423T201549Z-f02b

Conversation

@tarratsco
Copy link
Copy Markdown
Contributor

⚠️ AI-Generated PR — This pull request was automatically generated by Optimus. All code requires human review and testing before merging.

New schema — VA Form 26-8923

Summary

This PR introduces a new JSON Schema for VA Form 26-8923 (Interest Rate Reduction Refinancing Loan Worksheet). The schema covers:

  • Loan Identification: Header fields capturing the VA loan number, lender name, loan officer name, and officer title, all of which are required.
  • Shared Definitions: Reusable definition references including:
    • dollarAmount — a numeric type constrained between 0 and 9,999,999.99 for monetary fields.
    • percentageThreeDecimal — a numeric type constrained between 0 and 99.999 for interest rate and fee percentage fields.
    • isoDate — an ISO 8601 date string validated via both format: date and a ^\d{4}-\d{2}-\d{2}$ regex pattern.
  • additionalProperties: false is enforced at the root and on nested objects to prevent unrecognized fields.
  • Required field arrays are defined at the object level for strict validation of critical identifying information.

Files

  • src/schemas/26-8923/schema.js

Notes for reviewer

  • Please ensure you have incremented the version in package.json
  • Please add backend-review-group as a reviewer
  • The dollarAmount definition uses a maximum of 9999999.99 — please confirm this ceiling is appropriate for all monetary fields in the form (e.g., loan amounts, funding fees).
  • The percentageThreeDecimal definition supports up to three decimal places (e.g., 4.375) — verify this aligns with how interest rates are captured on the physical form.
  • vaLoanNumber is typed as a string — confirm whether any format constraint or length validation is expected for this field.
  • The isoDate definition uses both format and pattern for date validation; downstream consumers should be aware that format enforcement varies by validator implementation.

Pull Requests to update the schema in related repositories

  • vets-api: pending
  • vets-website: pending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant