This repository is currently being migrated. It's locked while the migration is in progress.
Add JSON Schema for VA Form 26-8923#1177
Draft
tarratsco wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New schema — VA Form 26-8923
Summary
This PR introduces a new JSON Schema for VA Form 26-8923 (Interest Rate Reduction Refinancing Loan Worksheet). The schema covers:
dollarAmount— a numeric type constrained between0and9,999,999.99for monetary fields.percentageThreeDecimal— a numeric type constrained between0and99.999for interest rate and fee percentage fields.isoDate— an ISO 8601 date string validated via bothformat: dateand a^\d{4}-\d{2}-\d{2}$regex pattern.additionalProperties: falseis enforced at the root and on nested objects to prevent unrecognized fields.Files
src/schemas/26-8923/schema.jsNotes for reviewer
package.jsonbackend-review-groupas a reviewerdollarAmountdefinition uses amaximumof9999999.99— please confirm this ceiling is appropriate for all monetary fields in the form (e.g., loan amounts, funding fees).percentageThreeDecimaldefinition supports up to three decimal places (e.g.,4.375) — verify this aligns with how interest rates are captured on the physical form.vaLoanNumberis typed as astring— confirm whether any format constraint or length validation is expected for this field.isoDatedefinition uses bothformatandpatternfor date validation; downstream consumers should be aware thatformatenforcement varies by validator implementation.Pull Requests to update the schema in related repositories