Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

Potential fix for code scanning alert no. 43: Inefficient regular expression#996

Draft
rjohnson2011 wants to merge 1 commit into
masterfrom
fix-inefficient-regex
Draft

Potential fix for code scanning alert no. 43: Inefficient regular expression#996
rjohnson2011 wants to merge 1 commit into
masterfrom
fix-inefficient-regex

Conversation

@rjohnson2011
Copy link
Copy Markdown

Potential fix for https://github.com/department-of-veterans-affairs/vets-json-schema/security/code-scanning/43

To fix the issue, we need to rewrite the regular expression to remove the ambiguity caused by overlapping matches. Specifically, we can replace the ambiguous [-a-zA-Z0-9/']+( ?) with a more precise pattern that explicitly matches a sequence of valid characters followed by an optional space. For example, we can use [-a-zA-Z0-9/'](?: [-a-zA-Z0-9/'])* to ensure that spaces are only allowed between valid character sequences, not at the end.

This change will preserve the original functionality while avoiding exponential backtracking. The fix should be applied to all instances of the problematic regex in the file.


Suggested fixes powered by Copilot Autofix. Review carefully before merging.

…ression

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant