Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VA-IIR 1426] set up initial form app for new version of 28-1900 form #34904

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

john-rodriguez-adhocteam
Copy link
Contributor

@john-rodriguez-adhocteam john-rodriguez-adhocteam commented Feb 25, 2025

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

If the folder you changed contains a manifest.json, search for its entryName in the content-build registry.json (the entryName there will match).

If an entry for this folder exists in content-build and you are:

  1. Deleting a folder:

    1. First search vets-website for all instances of the entryName in your manifest.json and remove them in a separate PR. Look particularly for references in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js. If you do not do this, other applications will break!
      • Add the link to your merged vets-website PR here
    2. Then, Delete the application entry in registry.json and merge that PR before this one
      • Add the link to your merged content-build PR here
  2. Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • This is work for the VA-IIR team.
  • We are temporarily assisting the Benefits team with the VR&E form over the next few months.
  • The form needs to be updated to match the latest paper form and web component versions. We were encouraged to create a newly constructed form.
  • This PR creates the initial set up of the new form app.
  • The new form app will be based on approved designs and the current version of the paper form.
  • The new form app will not be released to prod yet. The content-build PR linked below has vagovprod set to false.
  • The new form app will live at a temporary URL until a finalized URL is provided and then it will be updated.

Related issue(s)

What areas of the site does it impact?

None beyond this new app.

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/vre/new-28-1900/1426-new-vre-281900-setup/main February 25, 2025 21:41 Inactive
@john-rodriguez-adhocteam john-rodriguez-adhocteam marked this pull request as ready for review February 26, 2025 21:03
nicksayre
nicksayre previously approved these changes Feb 26, 2025
Copy link
Contributor

@nicksayre nicksayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial setup looks good. App runs as expected.

@va-vfs-bot va-vfs-bot temporarily deployed to master/vre/new-28-1900/1426-new-vre-281900-setup/vre/new-28-1900/1426-new-vre-281900-setup February 26, 2025 23:48 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/vre/new-28-1900/1426-new-vre-281900-setup/vre/new-28-1900/1426-new-vre-281900-setup February 27, 2025 16:13 Inactive
@nicksayre nicksayre self-requested a review February 27, 2025 16:16
@va-vfs-bot va-vfs-bot temporarily deployed to master/vre/new-28-1900/1426-new-vre-281900-setup/vre/new-28-1900/1426-new-vre-281900-setup February 27, 2025 20:52 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants