Conversation
f3b9edd to
fc37d30
Compare
|
@copilot resolve the merge conflicts in this pull request |
Resolved the merge conflict in |
23edd5f to
7561b13
Compare
There was a problem hiding this comment.
Pull request overview
Updates the MHV Medications application UI (refill flow + medications list) following UX review, primarily via link/content tweaks and layout/styling adjustments behind the existing mhvMedicationsManagementImprovements flag.
Changes:
- Updates refill page content (refill status link URL/text, removes prescription number from refill checkbox descriptions, adjusts empty-state heading level).
- Adjusts medications list UI layout/styling (sort dropdown container/width, pagination alignment, filter styling updates).
- Updates an e2e test to navigate directly to the details route and stub the details API call.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/applications/mhv-medications/tests/e2e/medications-non-VA-status-definition-dropdown-details-page.cypress.spec.js |
Updates e2e flow for the management-improvements-enabled scenario to visit details page directly and intercept the details request. |
src/applications/mhv-medications/sass/medications.scss |
Adds/adjusts styling for filter panel, sort dropdown container/width, and pagination alignment. |
src/applications/mhv-medications/containers/RefillPrescriptionsV2.jsx |
Updates refill step-guide link, removes prescription number from checkbox descriptions, and fixes heading hierarchy in empty state. |
src/applications/mhv-medications/components/MedicationsList/MedicationsListSort.jsx |
Wraps sort select in a new container to support intended inline layout adjustments. |
src/applications/mhv-medications/components/MedicationsList/MedicationsList.jsx |
Changes pagination alignment class on the medications list page. |
…dicationsList.jsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…sV2.jsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/department-of-veterans-affairs/vets-website/sessions/d808a595-437d-4ec1-8874-ad15a7a6f625 Co-authored-by: iseabock <994856+iseabock@users.noreply.github.com>
6bcfe4a to
080ebbf
Compare
Are you removing, renaming or moving a folder in this PR?
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the
#sitewide-public-websitesSlack channel for questions.Did you change site-wide styles, platform utilities or other infrastructure?
Summary
Multiple UI improvements to the MHV Medications Refill and Medication List pages:
href="#"to the correct URL (/my-health/medications/refill-status) and shortened text to "Check your refill status"<h2>to<h3>for correct heading hierarchyfit-contentwithmax-width: 250pxuseEffectthat bolds the label of the currently selected radio option in the medication list filter panelmhvMedicationsManagementImprovementsfeature flagRelated issue(s)
Testing done
Steps to verify:
yarn watch --env entry=mhv-medicationsmhvMedicationsManagementImprovementsin local mock togglesRefill page checks:
/my-health/medications/refill-status<h3>(inspect element)Medication list page checks:
Tests completed:
Screenshots
What areas of the site does it impact?
Changes isolated to MHV Medications application:
RefillPrescriptionsV2.jsx)MedicationsList.jsx,MedicationsListSort.jsx,MedicationListFilter.jsx)medications.scss)Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
useEffectwithsetTimeout(100ms)to query the DOM after Stencil web components finish rendering. This is becauseva-radio-optionuses scoped CSS that setsfont-weight: normalon its internal label, and the component does not expose::part()selectors. Open to alternative approaches if there's a better pattern for styling Stencil scoped component internals.