Skip to content

[CVE-2608] use formData fullName for statement of truth signature#44153

Merged
andresriveratoro merged 2 commits intomainfrom
cve-2608-qa
Apr 20, 2026
Merged

[CVE-2608] use formData fullName for statement of truth signature#44153
andresriveratoro merged 2 commits intomainfrom
cve-2608-qa

Conversation

@andresriveratoro
Copy link
Copy Markdown
Contributor

@andresriveratoro andresriveratoro commented Apr 16, 2026

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

Switch PreSubmitInfo2 to source the expected signature name from formData.fullName instead of the user profile, removing the unused user prop and updating tests accordingly.

Related issue(s)

Testing done

Updated unit tests to drop the buildUser helper and user prop from renders, supplied fullName via formData, and renamed the signature-match assertions to reference the expected name rather than the profile name.

Screenshots

N/A

What areas of the site does it impact?

COE form behind feature flag

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

@andresriveratoro andresriveratoro changed the title use formData fullName for statement of truth signature [CVE-2608] use formData fullName for statement of truth signature Apr 16, 2026
Comment thread src/applications/lgy/coe/form/components/PreSubmitInfo2.jsx Outdated
nicksayre
nicksayre previously approved these changes Apr 17, 2026
@andresriveratoro andresriveratoro marked this pull request as ready for review April 20, 2026 15:20
@andresriveratoro andresriveratoro requested review from a team as code owners April 20, 2026 15:20
@andresriveratoro andresriveratoro merged commit 32765cb into main Apr 20, 2026
82 checks passed
@andresriveratoro andresriveratoro deleted the cve-2608-qa branch April 20, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants