Skip to content

Refactor: Consistent Filtering of Releases in PackageLatestVersionFinder #12061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Apr 15, 2025

What are you trying to accomplish?

This change refactors the filtering logic for releases in PackageLatestVersionFinder to ensure consistent filtering across different version types. The goal is to apply the same filtering methodology to all releases, making the version filtering more robust and aligned with expected behavior across all ecosystems. This improves the maintainability and flexibility of version filtering.

Anything you want to highlight for special attention from reviewers?

  • Review the changes to the filtering logic for releases and ensure that all filtering now behaves consistently across different release types.
  • Check that this update doesn't introduce any regressions or breaking changes in how versions are filtered.
  • Verify that the logic for filtering releases works as expected, and the updates don't cause any unexpected behaviors.

How will you know you've accomplished your goal?

  • The full test suite passes without any regressions or issues in release filtering.
  • All version filtering logic is now consistently applied, and no issues arise from the changes.
  • Tests for the updated filtering logic pass successfully, confirming the correctness of the refactor.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@github-actions github-actions bot added L: javascript L: ruby:bundler RubyGems via bundler L: rust:cargo Rust crates via cargo labels Apr 15, 2025
@kbukum1 kbukum1 force-pushed the kamil/update_package_latest_version_finder_release_filters branch from dd6efa5 to bddc65f Compare April 15, 2025 03:00
@kbukum1 kbukum1 force-pushed the kamil/update_package_latest_version_finder_release_filters branch from 2ded70d to ec9b789 Compare April 15, 2025 05:29
@kbukum1 kbukum1 force-pushed the kamil/update_package_latest_version_finder_release_filters branch from ec9b789 to e84d805 Compare April 15, 2025 05:32
@kbukum1 kbukum1 marked this pull request as ready for review April 15, 2025 16:08
@kbukum1 kbukum1 requested a review from a team as a code owner April 15, 2025 16:08
@kbukum1 kbukum1 merged commit ef0f730 into main Apr 15, 2025
162 of 166 checks passed
@kbukum1 kbukum1 deleted the kamil/update_package_latest_version_finder_release_filters branch April 15, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: javascript L: ruby:bundler RubyGems via bundler L: rust:cargo Rust crates via cargo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants