Skip to content

Comments

fix: add support for nested maven properties#13746

Merged
JamieMagee merged 1 commit intodependabot:mainfrom
yeikel:nested/maven
Feb 19, 2026
Merged

fix: add support for nested maven properties#13746
JamieMagee merged 1 commit intodependabot:mainfrom
yeikel:nested/maven

Conversation

@yeikel
Copy link
Contributor

@yeikel yeikel commented Dec 10, 2025

What are you trying to accomplish?

Updates our maven parsing logic to allow parsing from more complex builds such as the ones that use nested properties

Fixes #13713
Fixes #13988
Fixes #13236

How will you know you've accomplished your goal?

Using the image from main, this is the output we can expect as documented in #13713

Reproducer: https://github.com/yeikel/dependabot-issue-13713

dependabot update -f job.json
... some logs omited for brevity
updater | +----------------------------------------------------------------------------------------------+
updater | | Errors |
updater | +---------------------------------+------------------------------------------------------------+
updater | | Type | Details |
updater | +---------------------------------+------------------------------------------------------------+
updater | | dependency_file_not_evaluatable | { |
updater | | | "message": "ERROR: Invalid expression: /project/.${grpc" |
updater | | | } |
updater | +---------------------------------+------------------------------------------------------------+

After this change:

proxy | 2025/12/10 00:44:05 [049] 200 http://host.docker.internal:58225/update_jobs/cli/create_pull_request
{"data":{"base-commit-sha":"2743e98a2a25267ae9bfdab9a4c756625c50e439"},"type":"mark_as_processed"}
proxy | 2025/12/10 00:44:05 [050] PATCH http://host.docker.internal:58225/update_jobs/cli/mark_as_processed
proxy | 2025/12/10 00:44:05 [050] 200 http://host.docker.internal:58225/update_jobs/cli/mark_as_processed
updater | 2025/12/10 00:44:05 INFO Finished job processing
updater | 2025/12/10 00:44:05 INFO Results:
updater | +--------------------------------------------------------+
updater | | Changes to Dependabot Pull Requests |
updater | +---------+----------------------------------------------+
updater | | created | io.grpc:grpc-netty ( from 1.76.2 to 1.77.0 ) |
updater | +---------+----------------------------------------------+
proxy | 2025/12/10 00:44:06 Skipping sending metrics because api endpoint is empty
proxy | 2025/12/10 00:44:06 5/23 calls cached (21%)

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@yeikel yeikel requested a review from a team as a code owner December 10, 2025 00:49
@github-actions github-actions bot added the L: java:maven Maven packages via Maven label Dec 10, 2025
@yeikel yeikel force-pushed the nested/maven branch 3 times, most recently from 20c0df6 to 5ce5175 Compare December 10, 2025 00:51
@yeikel yeikel force-pushed the nested/maven branch 2 times, most recently from 9c2bd11 to 982b18f Compare December 10, 2025 01:05
@yeikel yeikel changed the title Add support for nested maven properties fix: add support for nested maven properties Dec 10, 2025
@yeikel yeikel force-pushed the nested/maven branch 5 times, most recently from 772080a to 83767af Compare December 15, 2025 17:05
@yeikel yeikel closed this Dec 15, 2025
@yeikel yeikel reopened this Dec 15, 2025
@yeikel yeikel force-pushed the nested/maven branch 5 times, most recently from 9bccad8 to 3a61abf Compare December 19, 2025 04:36
@yeikel yeikel force-pushed the nested/maven branch 2 times, most recently from 488b043 to 7d6cc00 Compare January 5, 2026 16:14
@yeikel yeikel force-pushed the nested/maven branch 2 times, most recently from 40c56ac to 7f3357d Compare January 22, 2026 05:09
@kbukum1 kbukum1 moved this to Ready in Dependabot Jan 22, 2026
@yeikel yeikel force-pushed the nested/maven branch 4 times, most recently from ff8e3d5 to b04bb19 Compare February 2, 2026 20:01
@yeikel yeikel closed this Feb 3, 2026
@github-project-automation github-project-automation bot moved this from Ready to Done in Dependabot Feb 3, 2026
@yeikel yeikel reopened this Feb 3, 2026
@yeikel
Copy link
Contributor Author

yeikel commented Feb 4, 2026

@kbukum1 Please note that I updated the body because this change also fixes #13236 as well as one more scenario that @rhusar pointed out

@kbukum1
Copy link
Contributor

kbukum1 commented Feb 4, 2026

@kbukum1 Please note that I updated the body because this change also fixes #13236 as well as one more scenario that @rhusar pointed out

Thanks @yeikel, I will try to find sometime this week or maybe next week to review it. It seems to be fixing a few issues. So I need sometime to review it.

@yeikel yeikel force-pushed the nested/maven branch 7 times, most recently from 40a01f1 to 9b22db7 Compare February 8, 2026 01:54
@yeikel yeikel requested a review from JamieMagee February 12, 2026 03:36
@yeikel yeikel force-pushed the nested/maven branch 3 times, most recently from 3bbdff6 to e276191 Compare February 18, 2026 20:11
@yeikel
Copy link
Contributor Author

yeikel commented Feb 18, 2026

@kbukum1 Please note that I updated the body because this change also fixes #13236 as well as one more scenario that @rhusar pointed out

Thanks @yeikel, I will try to find sometime this week or maybe next week to review it. It seems to be fixing a few issues. So I need sometime to review it.

@kbukum1 Could you please take a look and let me know if you have any additional question, feedback or any scenario I should cover? Thanks as always for your time

Extends the Maven parsing logic to support nested properties

Fixes dependabot#13713
Fixes dependabot#13988
Fixes dependabot#13236
@JamieMagee JamieMagee merged commit c511045 into dependabot:main Feb 19, 2026
55 checks passed
@yeikel yeikel deleted the nested/maven branch February 19, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: java:maven Maven packages via Maven

Projects

Status: Done

4 participants